Add mapstruct-processor to annotation processor paths when Lombok and MapStruct are used#1175
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a project uses both Lombok and MapStruct,
UpgradeToJava17(viaAddLombokMapstructBinding+EnableLombokAnnotationProcessor) adds thelombok-mapstruct-bindingandlombokannotation processor paths, but never addsmapstruct-processor. Without it on the annotation processor path, MapStruct generates no mapper code once annotation processing is configured explicitly (required from Java 23 onward).Fix
New recipe
org.openrewrite.java.migrate.AddMapstructAnnotationProcessorPath, wired intoAddLombokMapstructBinding. It:org.mapstruct:mapstructversion, andmapstruct-processor<path>to themaven-compiler-pluginannotationProcessorPathsat that same version.It reuses the upstream
org.openrewrite.maven.AddAnnotationProcessorfor the actual insertion (so multi-module placement, "already configured" detection, andmaven-compiler-plugin3.12+ managed-version handling all carry over), supplying the version discovered during the scan phase. No-op when MapStruct isn't present.Tests
AddLombokMapstructBindingTest: newaddMapstructProcessorForMaven; existing Maven cases updated to include the new path;doesNotDuplicateMavenextended to assert idempotency for themapstruct-processorpath too. Gradle cases are unaffected (the recipe is Maven-only).UpgradeToJava17Test: newaddsMapstructProcessorWhenLombokAndMapstructUsedWithoutAnnotationProcessorPathsexercising the full chain from the issue —mapstruct-processoris added and tracks the upgraded MapStruct1.6.xversion.