Skip to content

Commit b7230af

Browse files
timtebeekTeamModerne
authored andcommitted
refactor: Equals avoids null
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.EqualsAvoidsNull?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw Co-authored-by: Moderne <team@moderne.io>
1 parent 2ca18f1 commit b7230af

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/main/java/org/openrewrite/openapi/swagger/MigrateApiImplicitParam.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,11 @@ private void addSchema(StringBuilder tpl, String key) {
106106
}
107107

108108
private boolean isDataTypeClass(Expression exp) {
109-
return exp instanceof J.Assignment && ((J.Identifier) ((J.Assignment) exp).getVariable()).getSimpleName().equals("dataTypeClass");
109+
return exp instanceof J.Assignment && "dataTypeClass".equals(((J.Identifier) ((J.Assignment) exp).getVariable()).getSimpleName());
110110
}
111111

112112
private boolean isDefaultValue(Expression exp) {
113-
return exp instanceof J.Assignment && ((J.Identifier) ((J.Assignment) exp).getVariable()).getSimpleName().equals("defaultValue");
113+
return exp instanceof J.Assignment && "defaultValue".equals(((J.Identifier) ((J.Assignment) exp).getVariable()).getSimpleName());
114114
}
115115
}
116116
);

src/main/java/org/openrewrite/openapi/swagger/MigrateApiParamDefaultValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ private void addSchema(StringBuilder tpl, String key) {
9898
}
9999

100100
private boolean isDefaultValue(Expression exp) {
101-
return exp instanceof J.Assignment && ((J.Identifier) ((J.Assignment) exp).getVariable()).getSimpleName().equals("defaultValue");
101+
return exp instanceof J.Assignment && "defaultValue".equals(((J.Identifier) ((J.Assignment) exp).getVariable()).getSimpleName());
102102
}
103103
}
104104
);

0 commit comments

Comments
 (0)