Skip to content

Commit 95ff73a

Browse files
authored
Keep mockStatic import in CleanupMockitoImports when type info is incomplete (#1047)
1 parent cba9383 commit 95ff73a

2 files changed

Lines changed: 23 additions & 0 deletions

File tree

src/main/java/org/openrewrite/java/testing/mockito/CleanupMockitoImports.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ private static class CleanupMockitoImportsVisitor extends JavaIsoVisitor<Executi
6767
"ignoreStubs",
6868
"inOrder",
6969
"mock",
70+
"mockConstruction",
71+
"mockStatic",
7072
"mockingDetails",
7173
"never",
7274
"only",

src/test/java/org/openrewrite/java/testing/mockito/CleanupMockitoImportsTest.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,27 @@ class OtherClass {
172172
);
173173
}
174174

175+
@Test
176+
void doNotRemoveMockStaticImportPossiblyAssociatedWithAnUntypedMockitoMethod() {
177+
//language=java
178+
rewriteRun(
179+
spec -> spec.typeValidationOptions(TypeValidation.all().methodInvocations(false)),
180+
java(
181+
"""
182+
import static org.mockito.Mockito.mockStatic;
183+
184+
class MyObjectTest {
185+
void test() {
186+
mockStatic(MyObject.class);
187+
}
188+
}
189+
class MyObject {
190+
}
191+
"""
192+
)
193+
);
194+
}
195+
175196
@Test
176197
void doNotRemoveStartImportsPossiblyAssociatedWithAnUntypedMockitoMethod() {
177198
//language=java

0 commit comments

Comments
 (0)