Lombok Best Practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.migrate.lombok.LombokBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <team@moderne.io>

Author: 2 people

src/main/java/org/openrewrite/java/testing/hamcrest/HamcrestMatcherToJUnit5.java

@@ -15,7 +15,9 @@
  */
 package org.openrewrite.java.testing.hamcrest;
 
+import lombok.AccessLevel;
 import lombok.Getter;
+import lombok.RequiredArgsConstructor;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
@@ -51,6 +53,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
                 new MigrationFromHamcrestVisitor());
     }
 
+    @RequiredArgsConstructor(access = AccessLevel.PACKAGE)
     enum Replacement {
         EQUALTO("equalTo", "assertEquals", "assertNotEquals", "#{any(java.lang.Object)}, #{any(java.lang.Object)}", "examinedObjThenMatcherArgs"),
         EMPTYARRAY("emptyArray", "assertEquals", "assertNotEquals", "0, #{anyArray(java.lang.Object)}.length", "examinedObjOnly"),
@@ -105,14 +108,6 @@ enum Replacement {
                 return arguments;
             });
         }
-
-        Replacement(String hamcrest, String junitPositive, String junitNegative, String template, String argumentsMethod) {
-            this.hamcrest = hamcrest;
-            this.junitPositive = junitPositive;
-            this.junitNegative = junitNegative;
-            this.template = template;
-            this.argumentsMethod = argumentsMethod;
-        }
     }
 
     private static class MigrationFromHamcrestVisitor extends JavaIsoVisitor<ExecutionContext> {

src/main/java/org/openrewrite/java/testing/jmockit/ArgumentMatchersRewriter.java

@@ -15,6 +15,8 @@
  */
 package org.openrewrite.java.testing.jmockit;
 
+import lombok.AccessLevel;
+import lombok.RequiredArgsConstructor;
 import org.openrewrite.Cursor;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.java.JavaParser;
@@ -26,6 +28,7 @@
 
 import static java.util.Collections.singletonList;
 
+@RequiredArgsConstructor(access = AccessLevel.PACKAGE)
 class ArgumentMatchersRewriter {
 
     private static final Set<String> JMOCKIT_ARGUMENT_MATCHERS = new HashSet<>();
@@ -78,12 +81,6 @@ class ArgumentMatchersRewriter {
     private final ExecutionContext ctx;
     private final J.Block expectationsBlock;
 
-    ArgumentMatchersRewriter(JavaVisitor<ExecutionContext> visitor, ExecutionContext ctx, J.Block expectationsBlock) {
-        this.visitor = visitor;
-        this.ctx = ctx;
-        this.expectationsBlock = expectationsBlock;
-    }
-
     J.Block rewriteJMockitBlock() {
         List<Statement> newStatements = new ArrayList<>(expectationsBlock.getStatements().size());
         for (Statement expectationStatement : expectationsBlock.getStatements()) {

src/main/java/org/openrewrite/java/testing/jmockit/JMockitBlockRewriter.java

@@ -17,6 +17,7 @@
 
 import lombok.AccessLevel;
 import lombok.Data;
+import lombok.Getter;
 import lombok.Setter;
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.Cursor;
@@ -63,12 +64,9 @@ private static String getObjectTemplateField(String fqn) {
     private J.Block methodBody;
     private JavaCoordinates nextStatementCoordinates;
 
+    @Getter(AccessLevel.PACKAGE)
     private boolean rewriteFailed = false;
 
-    boolean isRewriteFailed() {
-        return rewriteFailed;
-    }
-
     // keep track of the additional statements being added to the method body, which impacts the statement indices
     // used with bodyStatementIndex to obtain the coordinates of the next statement to be written
     private int numStatementsAdded = 0;

src/main/java/org/openrewrite/java/testing/jmockit/SetupStatementsRewriter.java

@@ -15,6 +15,8 @@
  */
 package org.openrewrite.java.testing.jmockit;
 
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.java.JavaVisitor;
 import org.openrewrite.java.tree.*;
@@ -26,16 +28,12 @@
 
 import static java.util.Collections.singletonList;
 
+@AllArgsConstructor(access = AccessLevel.PACKAGE)
 class SetupStatementsRewriter {
 
     private final JavaVisitor<ExecutionContext> visitor;
     private J.Block methodBody;
 
-    SetupStatementsRewriter(JavaVisitor<ExecutionContext> visitor, J.Block methodBody) {
-        this.visitor = visitor;
-        this.methodBody = methodBody;
-    }
-
     J.Block rewriteMethodBody() {
         List<Statement> statements = methodBody.getStatements();
         // iterate over each statement in the method body, find JMockit blocks and rewrite them

src/main/java/org/openrewrite/java/testing/junit5/TestRuleToTestInfo.java

@@ -16,6 +16,7 @@
 package org.openrewrite.java.testing.junit5;
 
 import lombok.Getter;
+import lombok.RequiredArgsConstructor;
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Preconditions;
@@ -144,6 +145,7 @@ public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, Ex
         }
     }
 
+    @RequiredArgsConstructor
     private static class BeforeMethodToTestInfoVisitor extends JavaIsoVisitor<ExecutionContext> {
         private final J.MethodDeclaration beforeMethod;
         private final J.VariableDeclarations varDecls;
@@ -154,12 +156,6 @@ private static class BeforeMethodToTestInfoVisitor extends JavaIsoVisitor<Execut
                         .classpathFromResources(ctx, "junit-jupiter-api-5");
         }
 
-        public BeforeMethodToTestInfoVisitor(J.MethodDeclaration beforeMethod, J.VariableDeclarations varDecls, String testMethodStatement) {
-            this.beforeMethod = beforeMethod;
-            this.varDecls = varDecls;
-            this.testMethodStatement = testMethodStatement;
-        }
-
         @Override
         public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) {
             J.MethodDeclaration md = super.visitMethodDeclaration(method, ctx);

src/main/java/org/openrewrite/java/testing/mockito/MockitoJUnitRunnerToExtension.java

@@ -15,7 +15,9 @@
  */
 package org.openrewrite.java.testing.mockito;
 
+import lombok.AccessLevel;
 import lombok.Getter;
+import lombok.RequiredArgsConstructor;
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Preconditions;
@@ -136,17 +138,14 @@ private Optional<JavaTemplate> getTemplate(Strictness strictness, ExecutionConte
         });
     }
 
+    @RequiredArgsConstructor(access = AccessLevel.PACKAGE)
     private enum Strictness {
         LENIENT("org.mockito.junit.MockitoJUnitRunner.Silent"),
         WARN("org.mockito.junit.MockitoJUnitRunner"),
         STRICT_STUBS("org.mockito.junit.MockitoJUnitRunner.Strict");
 
         final String runner;
 
-        Strictness(String runner) {
-            this.runner = runner;
-        }
-
         // Return true, if current strictness is greater than given strictness.
         boolean isGreaterThan(Strictness strictness) {
             return this.ordinal() > strictness.ordinal();