Fix UsesType precondition pattern in KotlinTestMethodsShouldReturnUnit (#1022)

UsesType matches against fully qualified type names, but the precondition was
given the two-token "org..* *Test*" pattern that AnnotationMatcher uses. That
only ever matched because of a TypeNameMatcher bug where a ..* token followed by
a suffix matched every name, fixed upstream in #8012. Use a valid single-token
glob org.junit..*Test* for the UsesType precondition; the AnnotationMatcher
pattern is unchanged.

Author: timtebeek

src/main/java/org/openrewrite/java/testing/cleanup/KotlinTestMethodsShouldReturnUnit.java

@@ -35,6 +35,9 @@
 public class KotlinTestMethodsShouldReturnUnit extends Recipe {
 
     private static final String TEST_ANNOTATION_PATTERN = "org..* *Test*";
+    // `UsesType` matches against fully qualified type names, so it needs a single-token glob rather
+    // than the two-token (`<owner> <name>`) form `AnnotationMatcher` uses above.
+    private static final String TEST_ANNOTATION_TYPE_PATTERN = "org.junit..*Test*";
     private static final JavaType.Class KOTLIN_UNIT = (JavaType.Class) JavaType.buildType("kotlin.Unit");
 
     @Getter
@@ -47,7 +50,7 @@ public class KotlinTestMethodsShouldReturnUnit extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return Preconditions.check(new UsesType<>(TEST_ANNOTATION_PATTERN, true), new KotlinIsoVisitor<ExecutionContext>() {
+        return Preconditions.check(new UsesType<>(TEST_ANNOTATION_TYPE_PATTERN, true), new KotlinIsoVisitor<ExecutionContext>() {
             @Override
             public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) {
                 J.MethodDeclaration m = super.visitMethodDeclaration(method, ctx);