Recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/builder/yESIGzVB0?organizationId=QUxML01vZGVybmUgKyBPcGVuUmV3cml0ZQ%3D%3D

Co-authored-by: Moderne <team@moderne.io>

Author: timtebeek

src/main/java/org/openrewrite/java/testing/assertj/DecomposeConjunctionAssertion.java

@@ -33,9 +33,7 @@
 import java.util.Set;
 
 import static java.util.Arrays.asList;
-import static java.util.Collections.emptyList;
-import static java.util.Collections.singleton;
-import static java.util.Collections.singletonList;
+import static java.util.Collections.*;
 
 public class DecomposeConjunctionAssertion extends Recipe {
 

src/main/java/org/openrewrite/java/testing/assertj/SimplifyAssertJInstanceOfAssertion.java

@@ -36,9 +36,7 @@
 
 import java.util.Set;
 
-import static java.util.Collections.emptyList;
-import static java.util.Collections.singleton;
-import static java.util.Collections.singletonList;
+import static java.util.Collections.*;
 
 public class SimplifyAssertJInstanceOfAssertion extends Recipe {
 

src/main/java/org/openrewrite/java/testing/assertj/SimplifyAssertJNullRelatedAssertion.java

@@ -16,6 +16,7 @@
 package org.openrewrite.java.testing.assertj;
 
 import lombok.Getter;
+import org.jspecify.annotations.Nullable;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
@@ -28,7 +29,6 @@
 import org.openrewrite.java.tree.Expression;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.Space;
-import org.jspecify.annotations.Nullable;
 
 import java.util.Set;
 

src/main/java/org/openrewrite/java/testing/cleanup/TestsShouldNotBePublic.java

@@ -34,11 +34,7 @@
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.TypeUtils;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
 
 import static java.util.Collections.singleton;
 import static java.util.stream.Collectors.toList;

src/main/java/org/openrewrite/java/testing/junit5/ImplausibleTimeoutToMinutes.java

@@ -47,19 +47,13 @@ public class ImplausibleTimeoutToMinutes extends Recipe {
     @Nullable
     Integer thresholdSeconds;
 
-    @Override
-    public String getDisplayName() {
-        return "Make implausibly long `@Timeout` values explicit in minutes";
-    }
+    String displayName = "Make implausibly long `@Timeout` values explicit in minutes";
 
-    @Override
-    public String getDescription() {
-        return "JUnit Jupiter's `@Timeout` defaults to `TimeUnit.SECONDS`, so a value such as `@Timeout(10000)` is " +
-                "interpreted as almost three hours, which is most likely a mistake where milliseconds were intended. " +
-                "This recipe rewrites such implausibly large second-based timeouts to the equivalent number of minutes, " +
-                "for instance `@Timeout(value = 167, unit = TimeUnit.MINUTES)`, preserving the original (likely " +
-                "erroneous) semantics while making the mistake far more visible for review.";
-    }
+    String description = "JUnit Jupiter's `@Timeout` defaults to `TimeUnit.SECONDS`, so a value such as `@Timeout(10000)` is " +
+            "interpreted as almost three hours, which is most likely a mistake where milliseconds were intended. " +
+            "This recipe rewrites such implausibly large second-based timeouts to the equivalent number of minutes, " +
+            "for instance `@Timeout(value = 167, unit = TimeUnit.MINUTES)`, preserving the original (likely " +
+            "erroneous) semantics while making the mistake far more visible for review.";
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/java/testing/mockito/PowerMockWhiteboxSetInternalStateToJavaReflection.java

@@ -66,9 +66,9 @@ private static class SetInternalStateVisitor extends WhiteboxToReflectionVisitor
                 return null;
             }
             String varName = generateVariableName(fieldName + "Field", scope, INCREMENT_NUMBER);
-            String prefix = mi.getArguments().size() == 4
-                    ? fieldLookupPrefixWhere(varName)
-                    : fieldLookupPrefix(varName);
+            String prefix = mi.getArguments().size() == 4 ?
+                    fieldLookupPrefixWhere(varName) :
+                    fieldLookupPrefix(varName);
             return prefix +
                     varName + ".set(#{any(java.lang.Object)}, #{any(java.lang.Object)});";
         }

src/main/java/org/openrewrite/java/testing/mockito/WhiteboxToReflectionVisitor.java

@@ -29,11 +29,7 @@
 import org.openrewrite.java.tree.*;
 import org.openrewrite.marker.Markers;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 
 import static java.util.Collections.emptyList;
 import static org.openrewrite.Tree.randomId;

src/test/java/org/openrewrite/java/testing/assertj/SimplifyArrayLengthAssertionTest.java

@@ -64,7 +64,6 @@ void testMethod(String[] array) {
         );
     }
 
-    @ParameterizedTest
     @CsvSource(delimiter = '|', value = {
       "assertThat(x.length).isZero()                    | assertThat(x).isEmpty()",
       "assertThat(x.length).isEqualTo(0)                | assertThat(x).isEmpty()",
@@ -75,6 +74,7 @@ void testMethod(String[] array) {
       "assertThat(x.length).isGreaterThan(4)            | assertThat(x).hasSizeGreaterThan(4)",
       "assertThat(x.length).isGreaterThanOrEqualTo(1)   | assertThat(x).hasSizeGreaterThanOrEqualTo(1)",
     })
+    @ParameterizedTest
     void simplifiesArrayLengthAssertions(String before, String after) {
         rewriteRun(
           //language=java

src/test/java/org/openrewrite/java/testing/mockito/ReplacePowerMockitoIntegrationTest.java

@@ -1846,8 +1846,8 @@ void testSomething() {
         );
     }
 
-    @Test
     @Issue("https://github.com/moderneinc/customer-requests/issues/2358")
+    @Test
     void whiteboxIsMigratedAndUnmigratableUsageIsFlagged() {
         //language=java
         rewriteRun(