Cleanup junit vintage engine (#993)

Author: sullis

src/main/resources/META-INF/rewrite/junit5.yml

@@ -103,10 +103,16 @@ recipeList:
   - org.openrewrite.java.dependencies.RemoveDependency:
       groupId: junit
       artifactId: junit
+  - org.openrewrite.maven.RemoveManagedDependency:
+      groupId: junit
+      artifactId: junit
   - org.openrewrite.java.testing.junit5.ExcludeJUnit4UnlessUsingTestcontainers
   - org.openrewrite.java.dependencies.RemoveDependency:
       groupId: org.junit.vintage
       artifactId: junit-vintage-engine
+  - org.openrewrite.maven.RemoveManagedDependency:
+      groupId: org.junit.vintage
+      artifactId: junit-vintage-engine
   - org.openrewrite.maven.ExcludeDependency:
       groupId: org.junit.vintage
       artifactId: junit-vintage-engine

src/test/java/org/openrewrite/java/testing/junit5/JUnit5MigrationTest.java

@@ -541,6 +541,128 @@ public void hello() {
         );
     }
 
+    @Test
+    void removeJunitVintageEngineFromMavenBuild() {
+        rewriteRun(
+          //language=xml
+          pomXml(
+            """
+              <project>
+                  <modelVersion>4.0.0</modelVersion>
+                  <groupId>com.example</groupId>
+                  <artifactId>my-project</artifactId>
+                  <version>1.0.0</version>
+                  <dependencies>
+                      <dependency>
+                          <groupId>junit</groupId>
+                          <artifactId>junit</artifactId>
+                          <version>4.13.2</version>
+                          <scope>test</scope>
+                      </dependency>
+                      <dependency>
+                          <groupId>org.junit.vintage</groupId>
+                          <artifactId>junit-vintage-engine</artifactId>
+                          <version>5.7.2</version>
+                          <scope>test</scope>
+                      </dependency>
+                  </dependencies>
+              </project>
+              """,
+            """
+              <project>
+                  <modelVersion>4.0.0</modelVersion>
+                  <groupId>com.example</groupId>
+                  <artifactId>my-project</artifactId>
+                  <version>1.0.0</version>
+              </project>
+              """
+          ),
+          srcTestJava(
+            java(
+              """
+                import org.junit.Test;
+
+                public class MyTest {
+                    @Test
+                    public void hello() {
+                    }
+                }
+                """,
+              """
+                import org.junit.jupiter.api.Test;
+
+                public class MyTest {
+                    @Test
+                    public void hello() {
+                    }
+                }
+                """
+            )
+          )
+        );
+    }
+
+    @Test
+    void removeJunitVintageEngineFromMavenDependencyManagement() {
+        rewriteRun(
+          //language=xml
+          pomXml(
+            """
+              <project>
+                  <modelVersion>4.0.0</modelVersion>
+                  <groupId>com.example</groupId>
+                  <artifactId>my-project</artifactId>
+                  <version>1.0.0</version>
+                  <dependencyManagement>
+                      <dependencies>
+                          <dependency>
+                              <groupId>junit</groupId>
+                              <artifactId>junit</artifactId>
+                              <version>4.13.2</version>
+                          </dependency>
+                          <dependency>
+                              <groupId>org.junit.vintage</groupId>
+                              <artifactId>junit-vintage-engine</artifactId>
+                              <version>5.7.2</version>
+                          </dependency>
+                      </dependencies>
+                  </dependencyManagement>
+              </project>
+              """,
+            """
+              <project>
+                  <modelVersion>4.0.0</modelVersion>
+                  <groupId>com.example</groupId>
+                  <artifactId>my-project</artifactId>
+                  <version>1.0.0</version>
+              </project>
+              """
+          ),
+          srcTestJava(
+            java(
+              """
+                import org.junit.Test;
+
+                public class MyTest {
+                    @Test
+                    public void hello() {
+                    }
+                }
+                """,
+              """
+                import org.junit.jupiter.api.Test;
+
+                public class MyTest {
+                    @Test
+                    public void hello() {
+                    }
+                }
+                """
+            )
+          )
+        );
+    }
+
     @Test
     void bumpSurefireOnOlderMavenVersions() {
         rewriteRun(