Skip to content

Commit fa03dcc

Browse files
OpenRewrite recipe best practices
Co-authored-by: Moderne <team@moderne.io>
1 parent 224c5eb commit fa03dcc

1 file changed

Lines changed: 35 additions & 33 deletions

File tree

src/test/java/org/openrewrite/java/testing/cleanup/AssertEqualsNullToAssertNullTest.java

Lines changed: 35 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
package org.openrewrite.java.testing.cleanup;
1717

1818
import org.junit.jupiter.api.Test;
19+
import org.openrewrite.DocumentExample;
1920
import org.openrewrite.InMemoryExecutionContext;
2021
import org.openrewrite.Issue;
2122
import org.openrewrite.java.JavaParser;
@@ -34,6 +35,40 @@ public void defaults(RecipeSpec spec) {
3435
.recipe(new AssertEqualsNullToAssertNull());
3536
}
3637

38+
@DocumentExample
39+
@Test
40+
void simplifyToAssertNullKotlin() {
41+
rewriteRun(
42+
//language=kotlin
43+
kotlin(
44+
"""
45+
import org.junit.jupiter.api.Assertions.assertEquals
46+
47+
class FooTest {
48+
fun test(values: List<String?>) {
49+
assertEquals(values[0], null)
50+
assertEquals(null, values[0])
51+
assertEquals(values[0], null, "message")
52+
assertEquals(null, values[0], "message")
53+
}
54+
}
55+
""",
56+
"""
57+
import org.junit.jupiter.api.Assertions.assertNull
58+
59+
class FooTest {
60+
fun test(values: List<String?>) {
61+
assertNull(values[0])
62+
assertNull(values[0])
63+
assertNull(values[0], "message")
64+
assertNull(values[0], "message")
65+
}
66+
}
67+
"""
68+
)
69+
);
70+
}
71+
3772
@Issue("https://github.com/openrewrite/rewrite-testing-frameworks/issues/200")
3873
@SuppressWarnings({"ConstantConditions", "SimplifiableAssertion"})
3974
@Test
@@ -107,37 +142,4 @@ void test() {
107142
)
108143
);
109144
}
110-
111-
@Test
112-
void simplifyToAssertNullKotlin() {
113-
rewriteRun(
114-
//language=kotlin
115-
kotlin(
116-
"""
117-
import org.junit.jupiter.api.Assertions.assertEquals
118-
119-
class FooTest {
120-
fun test(values: List<String?>) {
121-
assertEquals(values[0], null)
122-
assertEquals(null, values[0])
123-
assertEquals(values[0], null, "message")
124-
assertEquals(null, values[0], "message")
125-
}
126-
}
127-
""",
128-
"""
129-
import org.junit.jupiter.api.Assertions.assertNull
130-
131-
class FooTest {
132-
fun test(values: List<String?>) {
133-
assertNull(values[0])
134-
assertNull(values[0])
135-
assertNull(values[0], "message")
136-
assertNull(values[0], "message")
137-
}
138-
}
139-
"""
140-
)
141-
);
142-
}
143145
}

0 commit comments

Comments
 (0)