Skip to content

Fix UsesType precondition pattern in KotlinTestMethodsShouldReturnUnit #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 1 commit into from
Jun 16, 2026
+4 −1
Merged

Fix UsesType precondition pattern in KotlinTestMethodsShouldReturnUnit #1022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/org/openrewrite/java/testing/cleanup/KotlinTestMethodsShouldReturnUnit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
public class KotlinTestMethodsShouldReturnUnit extends Recipe {

private static final String TEST_ANNOTATION_PATTERN = "org..* *Test*";
// `UsesType` matches against fully qualified type names, so it needs a single-token glob rather
// than the two-token (`<owner> <name>`) form `AnnotationMatcher` uses above.
private static final String TEST_ANNOTATION_TYPE_PATTERN = "org.junit..*Test*";
private static final JavaType.Class KOTLIN_UNIT = (JavaType.Class) JavaType.buildType("kotlin.Unit");

@Getter
Expand All @@ -47,7 +50,7 @@ public class KotlinTestMethodsShouldReturnUnit extends Recipe {

@Override
public TreeVisitor<?, ExecutionContext> getVisitor() {
return Preconditions.check(new UsesType<>(TEST_ANNOTATION_PATTERN, true), new KotlinIsoVisitor<ExecutionContext>() {
return Preconditions.check(new UsesType<>(TEST_ANNOTATION_TYPE_PATTERN, true), new KotlinIsoVisitor<ExecutionContext>() {
@Override
public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) {
J.MethodDeclaration m = super.visitMethodDeclaration(method, ctx);
Expand Down
Loading