Fix Hamcrest not() unwrap infinite loop and support CoreMatchers#1054
Merged
Conversation
timtebeek
approved these changes
Jul 20, 2026
timtebeek
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks a lot! This explains why I was seeing timeouts with AssertJ indeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Two commits:
HamcrestMatcherToJUnit5/HamcrestInstanceOfToJUnit5on anot(...)matcher that isn'torg.hamcrest.Matchers.not.CoreMatchersvariants ofnot/instanceOf/isAinstead of skipping them.The hang
The unwrap loop continues on a name check but only makes progress on a type check, so they disagree:
A
CoreMatchers.not(or anotwith unresolved type) never gets stripped, the name stays"not", and the loop spins forever. Repro:Fix: loop on the matcher that decides strippability, so continuation and progress can't disagree:
No change to existing migrations.
CoreMatchers support
Broadens the three matchers from
org.hamcrest.Matcherstoorg.hamcrest.*Matchers(matches exactlyMatchersandCoreMatchers, identical methods), soCoreMatchers.not/instanceOf/isAmigrate too.Tests
notFromCoreMatchers(both recipes, asserting the real migration,@Timeout-guarded so a regressed hang fails fast) andinstanceOfAndIsAFromCoreMatchers. Full suite passes.