Commit 29fab0b
fix(sdk): classify not-found only by explicit FILE_NOT_FOUND code
Address review feedback: isFileNotFound() previously treated any HTTP
404 as not-found. A 404 whose body cannot be parsed is mapped to
UNEXPECTED_RESPONSE and may signal a real endpoint/routing regression;
downgrading those to DEBUG would hide genuine failures.
Restrict detection to the explicit SandboxError.FILE_NOT_FOUND code
(which the execd server returns for missing files) and add a
regression test covering a bare 404 + UNEXPECTED_RESPONSE.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 7d88455 commit 29fab0b
2 files changed
Lines changed: 20 additions & 1 deletion
File tree
- sdks/sandbox/kotlin/sandbox/src
- main/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/converter
- test/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/service
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
46 | 51 | | |
47 | 52 | | |
48 | 53 | | |
49 | 54 | | |
50 | | - | |
| 55 | + | |
51 | 56 | | |
52 | 57 | | |
53 | 58 | | |
| |||
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
124 | 138 | | |
125 | 139 | | |
126 | 140 | | |
| |||
0 commit comments