Commit 2a91287
feat(egress): wrap with supervisor + cleanup hook (#951)
* feat(egress): wrap with supervisor + cleanup hook
Hard-crashed egress leaves stale iptables/nft rules and a zombie mitmdump
holding port 18081; restarting the container then accumulates duplicate
rules and the new mitmdump fails to bind, sending the in-process mitm
watchdog (PR #942) into a retry loop. This change keeps the egress
process under a dedicated supervisor so restarts are deterministic and
the dirty state is reset on every launch and exit.
components/internal/supervisor: new shared single-worker supervisor.
Exponential backoff with jitter, pre-start / post-exit hooks (failures
non-fatal), crashloop circuit breaker, JSONL event log. SIGTERM is
forwarded to the worker with a configurable grace period before SIGKILL.
Includes unit + integration tests using a re-exec'd test binary as a
fake child.
components/internal/cmd/supervisor: opensandbox-supervisor binary built
from the same module; flag-driven, no new external deps.
components/egress/scripts/cleanup.sh: best-effort, idempotent reset of
the iptables DNS REDIRECT rules, transparent-HTTP rules, the
nftables `opensandbox` table, and stray mitmdump processes. Hard
contract: never exit non-zero so a misbehaving cleanup cannot block
restarts.
components/egress/Dockerfile: builds and installs the supervisor and
the cleanup script alongside the egress binary under
/opt/opensandbox-egress/, then switches the ENTRYPOINT to run the
supervisor with cleanup as both pre-start and post-exit, grace 20s to
cover the egress-internal shutdown budget.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* style(supervisor): gofmt
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(supervisor): jitter-disable, env aliasing, cleanup dedupe, tests
Self-review fixes:
- BackoffJitter is now *float64 so callers can pass &zero to disable
jitter explicitly. The previous default override turned 0 into 0.1,
making "no jitter" impossible. cmd/supervisor exposes the value via
--backoff-jitter (default 0.1).
- Build hookEnv into a fresh slice instead of `append(spec.Env, ...)`,
which could write into spec.Env's underlying array when cap > len.
- Hoist delete_until_gone to file scope in cleanup.sh; remove the two
inline duplicates.
- Add cmd/supervisor argv tests: splitOnDoubleDash table cases, toHooks,
openEventLog stderr + dir creation, eventLogDest label.
- Add backoff tests covering jitter=0 and applyDefaults() pointer
semantics.
- Document signal handling in the package doc: SIGINT/SIGTERM trigger
shutdown via ctx; SIGHUP / SIGUSR1 / SIGUSR2 / SIGWINCH / SIGQUIT are
NOT forwarded.
- Remove dead fakeClock.advance helper.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(egress): keep enforcement active during restart backoff
PR review (#951, Codex P1) caught a real security
regression: the post-exit cleanup hook was tearing down the iptables DNS
REDIRECT rules and the `inet opensandbox` nft table before the supervisor
slept for backoff and relaunched egress. Because the egress sidecar shares
its network namespace with the workload it is meant to filter, that window
left the workload with unfiltered egress instead of the stale default-deny
rules continuing to protect it. With a worst-case crashloop budget of
10 launches over 5 minutes, that window can stretch to minutes.
The fix is to leave netfilter state alone between runs:
- Drop the post-exit hook entirely. The backoff window now keeps the
previous run's enforcement rules in place.
- Slim cleanup.sh to mitmdump-reaping only. iptables rule accumulation
across many restarts is a slower-burn drift that egress's own
SetupRedirect tolerates (first match wins); the nftables manager
already prepends `delete table` to its ruleset script, so ApplyStatic
is idempotent. Neither needs hook intervention.
- Keep the pre-start mitmdump kill so the new egress can bind the
transparent-MITM listen port without colliding with an orphan.
(Codex P2 — zombie reaping when supervisor is PID 1 — is intentionally
not addressed in this commit; it does not gate the security fix.)
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>1 parent ce17955 commit 2a91287
15 files changed
Lines changed: 1882 additions & 3 deletions
File tree
- components
- egress
- scripts
- internal
- cmd/supervisor
- supervisor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| |||
55 | 58 | | |
56 | 59 | | |
57 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
58 | 78 | | |
59 | 79 | | |
60 | 80 | | |
| |||
91 | 111 | | |
92 | 112 | | |
93 | 113 | | |
94 | | - | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
95 | 126 | | |
96 | 127 | | |
97 | 128 | | |
98 | | - | |
99 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
0 commit comments