fix(allocator): avoid deleting non-existent pod allocations and improve error handling

- Add check to ensure pod exists in PodAllocation before deletion during release
- Update test cases to verify pod removal and recycling behavior correctly
- Return error immediately after logging failure to handle pod recycle in pool controller

Author: fengcone

kubernetes/internal/controller/allocator.go

@@ -412,9 +412,11 @@ func (allocator *defaultAllocator) doDeallocate(ctx context.Context, status *All
 		return false, err
 	}
 	for _, pod := range toRelease.Pods {
-		delete(status.PodAllocation, pod)
-		deallocate = true
-		status.PodsToRecycle = append(status.PodsToRecycle, pod)
+		if _, ok := status.PodAllocation[pod]; ok {
+			delete(status.PodAllocation, pod)
+			deallocate = true
+			status.PodsToRecycle = append(status.PodsToRecycle, pod)
+		}
 	}
 	pods := make([]string, 0)
 	for _, pod := range allocatedPods {

kubernetes/internal/controller/allocator_test.go

@@ -274,19 +274,25 @@ func TestAllocatorSchedule(t *testing.T) {
 					},
 				},
 			},
+			// Pod1 is allocated to sbx1 in pool level
 			poolAlloc: &PoolAllocation{
-				PodAllocation: map[string]string{},
+				PodAllocation: map[string]string{
+					"pod1": "sbx1",
+				},
 			},
+			// Sandbox has pod1 allocated
 			sandboxAlloc: &SandboxAllocation{
 				Pods: []string{
 					"pod1",
 				},
 			},
+			// Sandbox releases pod1
 			release: &AllocationRelease{
 				Pods: []string{
 					"pod1",
 				},
 			},
+			// Pod1 should be removed from allocation and added to recycle
 			wantStatus: &AllocStatus{
 				PodAllocation: map[string]string{},
 				PodSupplement: 0,

kubernetes/internal/controller/pool_controller.go

@@ -193,6 +193,7 @@ func (r *PoolReconciler) reconcilePool(ctx context.Context, pool *sandboxv1alpha
 			delay = defaultRetryTime
 			if err = r.handlePodRecycle(ctx, latestPool, pod); err != nil {
 				log.Error(err, "Failed to handle pod recycle", "pod", pod.Name)
+				return err
 			}
 		}
 		if int32(len(scheRes.idlePods)) >= scheRes.supplySandbox {