Skip to content

Commit 3714170

Browse files
committed
fix(sdk): make command timeout setters non-null
1 parent e07b9fd commit 3714170

3 files changed

Lines changed: 13 additions & 13 deletions

File tree

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/domain/models/execd/executions/RunCommandRequest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,17 +76,17 @@ class RunCommandRequest private constructor(
7676
* Maximum execution time; server will terminate the command when reached.
7777
* If omitted, the server will not enforce any timeout.
7878
*/
79-
fun timeout(timeout: Duration?): Builder {
79+
fun timeout(timeout: Duration): Builder {
8080
this.timeout = timeout
8181
return this
8282
}
8383

8484
@Deprecated(
8585
message = "Use java.time.Duration instead.",
86-
replaceWith = ReplaceWith("timeout(timeout?.toJavaDuration())", "kotlin.time.toJavaDuration"),
86+
replaceWith = ReplaceWith("timeout(timeout.toJavaDuration())", "kotlin.time.toJavaDuration"),
8787
)
88-
fun timeout(timeout: kotlin.time.Duration?): Builder {
89-
return timeout(timeout?.toJavaDuration())
88+
fun timeout(timeout: kotlin.time.Duration): Builder {
89+
return timeout(timeout.toJavaDuration())
9090
}
9191

9292
fun uid(uid: Int?): Builder {

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/domain/models/execd/executions/RunInSessionRequest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,17 +55,17 @@ class RunInSessionRequest private constructor(
5555
return this
5656
}
5757

58-
fun timeout(timeout: Duration?): Builder {
58+
fun timeout(timeout: Duration): Builder {
5959
this.timeout = timeout
6060
return this
6161
}
6262

6363
@Deprecated(
6464
message = "Use java.time.Duration instead.",
65-
replaceWith = ReplaceWith("timeout(timeout?.toJavaDuration())", "kotlin.time.toJavaDuration"),
65+
replaceWith = ReplaceWith("timeout(timeout.toJavaDuration())", "kotlin.time.toJavaDuration"),
6666
)
67-
fun timeout(timeout: kotlin.time.Duration?): Builder {
68-
return timeout(timeout?.toJavaDuration())
67+
fun timeout(timeout: kotlin.time.Duration): Builder {
68+
return timeout(timeout.toJavaDuration())
6969
}
7070

7171
fun handlers(handlers: ExecutionHandlers?): Builder {

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/domain/services/Commands.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,14 @@ interface Commands {
116116
workingDirectory: String? = null,
117117
timeout: Duration? = null,
118118
): Execution {
119-
return runInSession(
120-
sessionId,
119+
val builder =
121120
RunInSessionRequest.builder()
122121
.command(command)
123122
.workingDirectory(workingDirectory)
124-
.timeout(timeout)
125-
.build(),
126-
)
123+
if (timeout != null) {
124+
builder.timeout(timeout)
125+
}
126+
return runInSession(sessionId, builder.build())
127127
}
128128

129129
@Deprecated(

0 commit comments

Comments
 (0)