Skip to content

Commit 742fae9

Browse files
authored
Merge pull request #844 from Gujiassh/docs/helm-chart-versioning-758
docs(helm): clarify chart and app versioning
2 parents 759c2ef + ff2d8cd commit 742fae9

2 files changed

Lines changed: 23 additions & 0 deletions

File tree

kubernetes/charts/opensandbox-server/README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,16 @@ Optional: override gateway image, replicas, or resources (see `server.gateway.*`
5353
| `server.gateway.gatewayRouteMode` | server config and gateway route mode (header/uri) | `header` |
5454
| `server.gateway.*` | Gateway image, replicas, port, dataplaneNamespace, providerType, resources | See values.yaml |
5555

56+
Versioning note:
57+
58+
- `server.image.tag` defaults to the chart `appVersion`.
59+
- The chart package `version` and the image/app `appVersion` are intentionally
60+
separate. A server release branch or tag does not automatically imply a new
61+
Helm chart package version.
62+
- If you want the chart to deploy a specific server release, override
63+
`server.image.tag` explicitly or consume a Helm package release whose chart
64+
version was published for that purpose.
65+
5666
**Gateway**: When `server.gateway.enabled=true`, the chart writes `[ingress] mode = "gateway"` in config.toml and deploys **components/ingress** Deployment/Service/RBAC; gateway `--mode` matches config. External access must be configured separately.
5767

5868
Set `[kubernetes].namespace` in config for the sandbox workload namespace. Override `api_key` via Secret or values in production.

kubernetes/docs/HELM-DEPLOYMENT.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,19 @@ This automatically triggers the workflow to:
449449
4. Create a GitHub Release
450450
5. Publish the .tgz package to the Release
451451

452+
Important versioning note:
453+
454+
- The Helm chart `version` is the chart package version and is released through
455+
`helm/{component}/{version}` tags.
456+
- The chart `appVersion` is the default image/application version used by that
457+
chart release.
458+
- The `publish-helm-chart.yml` workflow updates `appVersion` for the published
459+
release, but intentionally does not auto-bump the chart `version` inside
460+
`Chart.yaml` on server release branches.
461+
- If you need a specific server image release, set the image tag explicitly
462+
(for example `--set server.image.tag=v0.1.13`) or publish a new Helm chart
463+
package version for the chart itself.
464+
452465
#### Option 2: Manual Trigger
453466

454467
1. Visit the GitHub Actions page

0 commit comments

Comments
 (0)