fix(sdk): reject oversized command timeouts

Author: ninan-nn

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/converter/ExecutionConverter.kt

@@ -18,6 +18,7 @@ package com.alibaba.opensandbox.sandbox.infrastructure.adapters.converter
 
 import com.alibaba.opensandbox.sandbox.domain.models.execd.executions.CommandStatus
 import com.alibaba.opensandbox.sandbox.domain.models.execd.executions.RunCommandRequest
+import java.time.Duration
 import com.alibaba.opensandbox.sandbox.api.models.execd.CommandStatusResponse as ApiCommandStatusResponse
 import com.alibaba.opensandbox.sandbox.api.models.execd.RunCommandRequest as ApiRunCommandRequest
 
@@ -27,7 +28,7 @@ object ExecutionConverter {
             command = command,
             background = background,
             cwd = workingDirectory,
-            timeout = timeout?.toMillis(),
+            timeout = timeout?.toCommandTimeoutMillis(),
             uid = uid,
             gid = gid,
             envs = envs,
@@ -46,3 +47,12 @@ object ExecutionConverter {
         )
     }
 }
+
+internal fun Duration.toCommandTimeoutMillis(): Long {
+    require(!isNegative) { "Timeout must be non-negative, got: $this" }
+    return try {
+        toMillis()
+    } catch (e: ArithmeticException) {
+        throw IllegalArgumentException("Timeout is too large to represent in milliseconds: $this", e)
+    }
+}

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/service/CommandsAdapter.kt

@@ -42,6 +42,7 @@ import com.alibaba.opensandbox.sandbox.infrastructure.adapters.converter.Executi
 import com.alibaba.opensandbox.sandbox.infrastructure.adapters.converter.ExecutionEventDispatcher
 import com.alibaba.opensandbox.sandbox.infrastructure.adapters.converter.jsonParser
 import com.alibaba.opensandbox.sandbox.infrastructure.adapters.converter.parseSandboxError
+import com.alibaba.opensandbox.sandbox.infrastructure.adapters.converter.toCommandTimeoutMillis
 import com.alibaba.opensandbox.sandbox.infrastructure.adapters.converter.toSandboxException
 import okhttp3.Headers.Companion.toHeaders
 import okhttp3.HttpUrl.Companion.toHttpUrlOrNull
@@ -196,7 +197,7 @@ internal class CommandsAdapter(
                 RunInSessionRequestApi(
                     command = request.command,
                     cwd = request.workingDirectory,
-                    timeout = request.timeout?.toMillis(),
+                    timeout = request.timeout?.toCommandTimeoutMillis(),
                 )
             val runUrl =
                 execdBaseUrl

sdks/sandbox/kotlin/sandbox/src/test/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/adapters/service/CommandsAdapterTest.kt

@@ -25,6 +25,7 @@ import com.alibaba.opensandbox.sandbox.domain.models.execd.executions.ExecutionH
 import com.alibaba.opensandbox.sandbox.domain.models.execd.executions.RunCommandRequest
 import com.alibaba.opensandbox.sandbox.domain.models.execd.executions.RunInSessionRequest
 import com.alibaba.opensandbox.sandbox.domain.models.sandboxes.SandboxEndpoint
+import com.alibaba.opensandbox.sandbox.infrastructure.adapters.converter.toCommandTimeoutMillis
 import kotlinx.serialization.json.Json
 import kotlinx.serialization.json.booleanOrNull
 import kotlinx.serialization.json.intOrNull
@@ -359,6 +360,15 @@ data: {"type":"execution_complete","execution_time":100,"timestamp":167253120100
         assertEquals(5000L, requestBodyJson["timeout"]?.jsonPrimitive?.content?.toLong())
     }
 
+    @Test
+    fun `command timeout conversion should reject durations too large for milliseconds`() {
+        val exception =
+            assertThrows(IllegalArgumentException::class.java) {
+                Duration.ofSeconds(Long.MAX_VALUE).toCommandTimeoutMillis()
+            }
+        assertTrue(exception.message!!.contains("too large to represent in milliseconds"))
+    }
+
     @Test
     fun `runInSession should infer non-zero exit code from command error event`() {
         val initEvent = """data: {"type":"init","text":"cmd-123","timestamp":1672531200000}"""