-
Notifications
You must be signed in to change notification settings - Fork 932
fix(sdk): use java duration for command request timeouts #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pangjiping
merged 4 commits into
opensandbox-group:main
from
ninan-nn:feature/minor_update_20260521
May 25, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5850909
fix(sdk): use java duration for Kotlin command timeouts
ninan-nn e07b9fd
fix(sdk): add kotlin duration compatibility overloads
ninan-nn 3714170
fix(sdk): make command timeout setters non-null
ninan-nn f8d2572
fix(sdk): reject oversized command timeouts
ninan-nn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
...n/com/alibaba/opensandbox/sandbox/domain/models/execd/executions/RunCommandRequestTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Copyright 2025 Alibaba Group Holding Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.alibaba.opensandbox.sandbox.domain.models.execd.executions | ||
|
|
||
| import org.junit.jupiter.api.Assertions.assertEquals | ||
| import org.junit.jupiter.api.Test | ||
| import java.time.Duration | ||
| import kotlin.time.Duration.Companion.seconds | ||
|
|
||
| class RunCommandRequestTest { | ||
| @Test | ||
| fun `builder accepts java duration for timeout`() { | ||
| val request = | ||
| RunCommandRequest.builder() | ||
| .command("echo hi") | ||
| .timeout(Duration.ofSeconds(5)) | ||
| .build() | ||
|
|
||
| assertEquals(Duration.ofSeconds(5), request.timeout) | ||
| } | ||
|
|
||
| @Suppress("DEPRECATION") | ||
| @Test | ||
| fun `builder accepts deprecated kotlin duration for timeout`() { | ||
| val request = | ||
| RunCommandRequest.builder() | ||
| .command("echo hi") | ||
| .timeout(5.seconds) | ||
| .build() | ||
|
|
||
| assertEquals(Duration.ofSeconds(5), request.timeout) | ||
| } | ||
| } |
47 changes: 47 additions & 0 deletions
47
...com/alibaba/opensandbox/sandbox/domain/models/execd/executions/RunInSessionRequestTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Copyright 2025 Alibaba Group Holding Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.alibaba.opensandbox.sandbox.domain.models.execd.executions | ||
|
|
||
| import org.junit.jupiter.api.Assertions.assertEquals | ||
| import org.junit.jupiter.api.Test | ||
| import java.time.Duration | ||
| import kotlin.time.Duration.Companion.seconds | ||
|
|
||
| class RunInSessionRequestTest { | ||
| @Test | ||
| fun `builder accepts java duration for timeout`() { | ||
| val request = | ||
| RunInSessionRequest.builder() | ||
| .command("echo hi") | ||
| .timeout(Duration.ofSeconds(5)) | ||
| .build() | ||
|
|
||
| assertEquals(Duration.ofSeconds(5), request.timeout) | ||
| } | ||
|
|
||
| @Suppress("DEPRECATION") | ||
| @Test | ||
| fun `builder accepts deprecated kotlin duration for timeout`() { | ||
| val request = | ||
| RunInSessionRequest.builder() | ||
| .command("echo hi") | ||
| .timeout(5.seconds) | ||
| .build() | ||
|
|
||
| assertEquals(Duration.ofSeconds(5), request.timeout) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.