fix(server): Reject conflicting endpoint modes#952
Merged
hittyt merged 1 commit intoMay 28, 2026
Merged
Conversation
Gujiassh
requested review from
Generalwin,
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_server_proxy=truewithexpires, because that combination asks for both the server proxy path and a signed gateway route.SANDBOX::INVALID_PARAMETERerror instead of resolving a signed endpoint and then overwriting it with a proxy URL.Closes #949
Validation
cd server && uv run pytest tests/test_routes_endpoint_behavior.py -qcd server && uv run ruff check opensandbox_server/api/lifecycle.py tests/test_routes_endpoint_behavior.pycd server && uv run ruff format --check tests/test_routes_endpoint_behavior.pygit diff --check