-
Notifications
You must be signed in to change notification settings - Fork 927
feat(server): implement multi-tenancy provider with file and HTTP backends #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pangjiping
wants to merge
6
commits into
opensandbox-group:main
Choose a base branch
from
Pangjiping:feature/multi-tenancy-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
21efcf4
feat(server): implement multi-tenancy provider with file and HTTP bac…
Pangjiping 827df7e
docs(osep): mark OSEP-0012 multi-tenancy as implemented
Pangjiping 7d51e00
fix(server): remove unused imports flagged by ruff
Pangjiping cb11d2b
test(e2e): add multi-tenant file and HTTP provider e2e tests
Pangjiping bbdbc1c
fix(e2e): improve host IP detection for multi-tenant HTTP mock
Pangjiping d02b0be
fix(server): address multi-tenancy PR review feedback
Pangjiping File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file provider is documented and implemented as a hot-reloading
tenants.toml, but the Helm chart mounts the ConfigMap key viasubPath; Kubernetes documents that ConfigMap mounts usingsubPathdo not receive updates when the ConfigMap changes. As a result, updatingtenantsTomlin a Helm release will not change/etc/opensandbox/tenants.tomlin the running server pod, so key rotation/add/remove will not be observed until the pod restarts.Useful? React with 👍 / 👎.