Skip to content

feat(deps): bump tree-sitter to 0.26#7

Merged
mkatychev merged 6 commits into
openscad:mainfrom
fenollp:bump_tree-sitter
Jan 23, 2026
Merged

feat(deps): bump tree-sitter to 0.26#7
mkatychev merged 6 commits into
openscad:mainfrom
fenollp:bump_tree-sitter

Conversation

@fenollp
Copy link
Copy Markdown
Contributor

@fenollp fenollp commented Jan 17, 2026

No description provided.

Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
@mkatychev
Copy link
Copy Markdown
Member

mkatychev commented Jan 20, 2026

Hi @fenollp, thanks for the PR could you please run tree sitter init --update so that other dependencies are updated as well?

Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
@fenollp
Copy link
Copy Markdown
Contributor Author

fenollp commented Jan 22, 2026

Done! With

tree-sitter 0.26.3

Copy link
Copy Markdown
Member

@mkatychev mkatychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your changes!

@mkatychev
Copy link
Copy Markdown
Member

@fenollp looks like you need to run tree-sitter gen as well based on the failing CI tests

Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
@fenollp
Copy link
Copy Markdown
Contributor Author

fenollp commented Jan 23, 2026

Done :)

@mkatychev mkatychev self-requested a review January 23, 2026 19:12
@mkatychev
Copy link
Copy Markdown
Member

mkatychev commented Jan 23, 2026

@fenollp I've fixed the failing linter issues in
could you fix up the errors in https://github.com/openscad/tree-sitter-openscad/actions/runs/21298087395/job/61308789883#step:4:419?
It looks like tree-sitter update --init reverts the package name from the one explicitly specified for crates.io

EDIT: I've actually done this myself

@mkatychev
Copy link
Copy Markdown
Member

We will have to wait for https://www.npmjs.com/package/tree-sitter to publish 0.25.1 before reenabling the node tests

@mkatychev mkatychev merged commit f74f305 into openscad:main Jan 23, 2026
3 checks passed
@fenollp fenollp deleted the bump_tree-sitter branch January 26, 2026 16:31
@fenollp
Copy link
Copy Markdown
Contributor Author

fenollp commented Jan 26, 2026

Thanks @mkatychev !
How about publishing this crate to crates.io? I see v0.6.2 is tagged but doesn't appear at https://crates.io/crates/tree-sitter-openscad-ng/versions
Also this change probably means publishing v0.6.3

@mkatychev
Copy link
Copy Markdown
Member

@fenollp good call, I think I was trying to get v0.6.2 to publish through CI but ran into issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants