Improve logrotate parameters based on Mat's feedback

Author: Marissa Zhang

Dockerfile.testing

@@ -28,8 +28,8 @@ RUN pip3 install -U pip && pip3 install -r /opt/registry/requirements.txt
 # Use our weird grid-security cert/key location
 RUN rm /etc/httpd/conf.d/ssl.conf
 
-# Setup cron job for logrotate to run every 5 minutes
-RUN crontab -l | { cat; echo "* * * * * /usr/sbin/logrotate /etc/logrotate.d/httpd >> /var/log/cron 2>&1"; } | crontab -
+# Setup cron job for logrotate to run as root every day  
+RUN echo "0 0 * * * root /usr/sbin/logrotate /etc/logrotate.d/httpd >> /var/log/cron 2>&1" > /etc/cron.d/logrotate-httpd  
 
 COPY register.py /usr/bin
 COPY supervisor-apache.conf /etc/supervisord.d/40-apache.conf

logrotate-http.conf

@@ -1,14 +1,12 @@
 /var/log/httpd/*.log {
-    maxsize 10K
-    dateext
-    dateformat -%Y%m%d-%s
-    rotate 2
+    maxsize 100M  
+    rotate 20 
     missingok
     notifempty
     compress
     delaycompress
     sharedscripts
     postrotate
-        PID=$(pgrep -o httpd) && kill -USR1 $PID
+        PID=$(pgrep -o httpd); if [ "$PID" ]; then kill -USR1 $PID; fi 
     endscript
 }