macOS: peers list/table text overlaps after updating Transmission to 4.1.0 (app v1.5.1)

[sHAsHiLx]

App version: 1.5.1
OS: macOS
Transmission: 4.1.0

Context:
The issue started right after updating Transmission to 4.1.0. Before that, the peers list/table rendered normally.

Problem:
In the peers list/table, the text rendering breaks: IP addresses, country names/flags and other columns overlap each other, making the list unreadable (see attached screenshot).

Steps to reproduce:

1. Update Transmission to 4.1.0
2. Open the app
3. Open a torrent and view the peers list/table
4. Observe overlapping/stacked text in rows/columns

Expected:
Rows and columns render normally, each value stays within its column.

Actual:
Multiple columns are drawn on top of each other (overlapping text), rows become unreadable.

Attachments:

• Screenshot showing the overlapping text in peers list/table

[qu1ck]

I can reproduce something strange is going on with caching, I don't think it's related to 4.1.0 update.

[qu1ck]

This is starting to look like webkitgtk/react bug to me. React says there is only one row but another row is stuck in the table

[qu1ck]

I think I found the issue, transmission now often sends peers with same ip:port which causes issues when used as key in react. I think I fixed it, at least for 4.1.0, not sure this was ever an issue in prior versions since I never ran into it.

[sHAsHiLx]

Tried Version e7453d7 (Feb 1, 6:40 AM GMT+2) - and it still have this bug.

[ckerr]

I think I found the issue, transmission now often sends peers with same ip:port which causes issues when used as key in react. I think I fixed it, at least for 4.1.0, not sure this was ever an issue in prior versions since I never ran into it.

@qu1ck could you be more descriptive about this? I think I understand what you're saying but am not positive, so I'd like make sure before I go diving in to Transmission's code to try & repro the issue.

[qu1ck]

@ckerr My previous code assumed that ip:port pair would be unique and used it as a key. Not sure if it was actually unique but it wasn't an issue before 4.1. However with 4.1 I've observed transmission returning an array of peers with duplicate ip:port pair, however one was encrypted and the other wasn't, they also had distinct peer_id. So now I'm using peer_id as a key if it is available, is that one also not unique?