Some codes don't parse correctly

[scruffian]

Some example codes from the morphhb repo that don't parse correctly:

• HVqrmsa, HVprmsa, HVqrmpc, HVqrmsc
• HPp3fs

I'll add more as I find them

[jag3773]

@scruffian Can you note where you've found these?

[scruffian]

I found these here: https://github.com/openscriptures/morphhb, for example: https://github.com/openscriptures/morphhb/blob/master/wlc/1Chr.xml

[scruffian]

Any thoughts on why this is and what we can do to fix it?

[joeldruark]

@scruffian I'm taking a look at this, but I'm not following you when you say that "the codes don't parse correctly." Can you explain the problem a little more specifically?

[scruffian]

Sure, I'm using the parsing code in this repo, and calling this: parser.Parse(HVqrmsa) and it returns undefined for part of the morphology. For example:

var parser = new MorphParse();
parser.Parse('HVqrmsa');
"Verb qal participle active undefined undefined undefined"```

[joeldruark]

OK, I think I understand. This is not a problem with the parsing data itself (i.e. where Hebrew forms are incorrectly parsed in the OSHB). This is a problem in the programming code that displays itself when trying to manipulate certain aspects of the parsing data. Have I understood you correctly, @scruffian ?

[scruffian]

I'm not sure where the problem is, which is why I haven't submitted a patch. It could be that the parsing code needs updating to accommodate these forms, or it could be that the forms themselves are incorrect.

For example HVqrmsa fails to parse because it doesn't have a Person element. Either we need to make sure that all these forms are updated to have a Person, or we need to change the code to allow it to parse forms with missing elements. What do you think?

[joeldruark]

@scruffian Ah, I understand what you're saying. The HVqrmsa form is a participle, and participles do not indicate person. Likewise, finite verbs do not indicate construct/absolute state, nouns do not indicate stem formation, etc. Not all morphological forms have the same parsing elements, so we need to change the code to allow it to parse forms according to the specific elements that are applicable.

[joeldruark]

@jag3773 has indicated to me that he thinks this is David Troidl's code.

[scruffian]

Makes sense. I'll work up a fix if I have time :)