Fix repository-gcs KeyStore.getInstance type/provider order

GoogleCloudStorageService.createFipsCompliantGoogleTrustStore called
KeyStore.getInstance("BCFIPS", "BCFIPS"), but "BCFIPS" is the
provider name; the corresponding keystore type is "BCFKS" (already
documented in the in-method comment one line above). Every GCS snapshot
operation on a FIPS-enabled OpenSearch 3.7.0 distribution therefore
fails with:

  KeyStoreException: BCFIPS not found
    caused by: NoSuchAlgorithmException: no such algorithm: BCFIPS for
    provider BCFIPS

Fixes #22287.

Signed-off-by: Guillaume SZKOPINSKI <guillaume.szkopinski@altirnao.com>

Author: gszkopinski

plugins/repository-gcs/src/main/java/org/opensearch/repositories/gcs/GoogleCloudStorageService.java

@@ -304,7 +304,7 @@ static Integer toTimeout(final TimeValue timeout) {
 
     private KeyStore createFipsCompliantGoogleTrustStore() throws GeneralSecurityException, IOException {
         // Use BCFKS KeyStore type which is required for FIPS mode
-        KeyStore trustStore = KeyStore.getInstance("BCFIPS", "BCFIPS");
+        KeyStore trustStore = KeyStore.getInstance("BCFKS", "BCFIPS");
         // Initialize empty BCFKS trust store
         trustStore.load(null, null);
 
@@ -323,3 +323,4 @@ private KeyStore createFipsCompliantGoogleTrustStore() throws GeneralSecurityExc
         return trustStore;
     }
 }
+