Skip to content

Commit 30920ea

Browse files
MayankHarsh03Mayank Harsh
andauthored
Fix BlockTransferManagerTests to extend OpenSearchTestCase instead of LuceneTestCase (#21363)
BlockTransferManagerTests was extending LuceneTestCase directly which causes sysout check failures since the test uses loggers that print to console. Changed to extend OpenSearchTestCase which already includes @SuppressSysoutChecks and follows the project convention for all server tests. Signed-off-by: Mayank Harsh <mayankmh@amazon.com> Co-authored-by: Mayank Harsh <mayankmh@amazon.com>
1 parent 3cd9aa6 commit 30920ea

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

server/src/test/java/org/opensearch/storage/common/BlockTransferManagerTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
import org.apache.lucene.store.FSDirectory;
1414
import org.apache.lucene.store.IOContext;
15-
import org.apache.lucene.tests.util.LuceneTestCase;
1615
import org.opensearch.Version;
1716
import org.opensearch.cluster.metadata.IndexMetadata;
1817
import org.opensearch.common.UUIDs;
@@ -23,6 +22,7 @@
2322
import org.opensearch.index.store.remote.utils.TransferManager;
2423
import org.opensearch.node.Node;
2524
import org.opensearch.storage.indexinput.BlockFetchRequest;
25+
import org.opensearch.test.OpenSearchTestCase;
2626
import org.opensearch.threadpool.ThreadPool;
2727
import org.junit.After;
2828
import org.junit.Assert;
@@ -52,7 +52,7 @@
5252
* Tests cover single block downloads, failure scenarios, duplicate handling, and concurrent operations.
5353
*/
5454
@ThreadLeakFilters(filters = CleanerDaemonThreadLeakFilter.class)
55-
public class BlockTransferManagerTests extends LuceneTestCase {
55+
public class BlockTransferManagerTests extends OpenSearchTestCase {
5656

5757
// Node and index configuration constants
5858
private static final String TEST_NODE_NAME = "test-node";

0 commit comments

Comments
 (0)