Skip to content

Commit be091ed

Browse files
committed
TODO: centralise annotation stripping in FragmentConversionDriver
Per PR 22086 review feedback (expani, mch2): adapters shouldn't be stripping OperatorAnnotation themselves; the driver should normalise the tree. Tag the local strip helper as a follow-up so the cleanup covers every adapter doing this together. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
1 parent 459ec2c commit be091ed

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

sandbox/plugins/analytics-backend-datafusion/src/main/java/org/opensearch/be/datafusion/ComparisonTemporalCoercionAdapter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ private static RexNode unwrapToTime(RexNode node) {
110110
return null;
111111
}
112112

113+
// TODO: annotation stripping should be centralised in FragmentConversionDriver; revisit alongside the other adapters that strip
114+
// locally.
113115
private static RexNode stripAnnotation(RexNode node) {
114116
while (node instanceof OperatorAnnotation annotation && annotation.unwrap() != null) {
115117
node = annotation.unwrap();

0 commit comments

Comments
 (0)