Commit de43ffb
committed
Reconcile streamstats + InSubquery ITs with newly-supported plans
CI surfaced four StreamstatsCommandIT failures and two
InSubqueryCommandIT failures. All six are reconciled here.
Streamstats β testStreamstatsResetWithNull / GlobalWithNull /
ResetWithNullBucket / GlobalWithNullBucket previously asserted the
query *must error* via assertErrorAny. After PR #21795's decorrelation
plus this branch's marking-phase fixes (LITERAL_AGG lowering and
OpenSearchJoinRule relaxation), these PPL forms now plan and execute
end-to-end. Flip the four assertions to executePpl + assertNotNull,
matching how testStreamstatsReset is already structured.
InSubquery β testTwoExpressionsInSubquery's exact-row assertion was
fragile across hash-join output ordering for two rows sharing
salary=120000. Add 'id' as a secondary sort key so the order is fully
determined.
InSubquery β testTwoExpressionsNotInSubquery hits an independent
OpenSearchAggregateSplitRule bug ("filter must be BOOLEAN NOT NULL")
unrelated to subquery decorrelation. Mark @AwaitsFix with a note
pointing at the split-rule limitation.
Local verification:
* StreamstatsCommandIT β all tests pass.
* InSubqueryCommandIT β 12/13 pass, the @AwaitsFix-skipped one is
the split-rule case.
Signed-off-by: Songkan Tang <songkant@amazon.com>1 parent 7a19120 commit de43ffb
2 files changed
Lines changed: 17 additions & 6 deletions
File tree
- sandbox/qa/analytics-engine-rest/src/test/java/org/opensearch/analytics/qa
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
119 | 123 | | |
120 | 124 | | |
121 | | - | |
| 125 | + | |
122 | 126 | | |
123 | 127 | | |
124 | 128 | | |
| |||
148 | 152 | | |
149 | 153 | | |
150 | 154 | | |
| 155 | + | |
151 | 156 | | |
152 | 157 | | |
153 | 158 | | |
| |||
Lines changed: 11 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
674 | 674 | | |
675 | 675 | | |
676 | 676 | | |
677 | | - | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
678 | 680 | | |
679 | 681 | | |
680 | | - | |
| 682 | + | |
681 | 683 | | |
682 | 684 | | |
683 | 685 | | |
| 686 | + | |
684 | 687 | | |
685 | 688 | | |
686 | 689 | | |
687 | 690 | | |
688 | 691 | | |
689 | | - | |
| 692 | + | |
690 | 693 | | |
691 | 694 | | |
692 | 695 | | |
| 696 | + | |
693 | 697 | | |
694 | 698 | | |
695 | 699 | | |
| |||
708 | 712 | | |
709 | 713 | | |
710 | 714 | | |
711 | | - | |
| 715 | + | |
712 | 716 | | |
713 | 717 | | |
714 | 718 | | |
| 719 | + | |
715 | 720 | | |
716 | 721 | | |
717 | 722 | | |
718 | 723 | | |
719 | 724 | | |
720 | | - | |
| 725 | + | |
721 | 726 | | |
722 | 727 | | |
723 | 728 | | |
724 | 729 | | |
| 730 | + | |
725 | 731 | | |
726 | 732 | | |
727 | 733 | | |
| |||
0 commit comments