Extended UT Framework for E2E Query conversion#21227
Extended UT Framework for E2E Query conversion#21227bharath-techie merged 5 commits intoopensearch-project:mainfrom
Conversation
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 1f07e44.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
|
Thanks for the PR @nssuresh2007 I like the approach of representing everything in JSON files so it's clear how the conversion happens completely end to end from DSL -> RelNode -> SearchResponse Considering @vinaykpud comment #21060 (comment) in the previous PR i think we should also consider reusing this JSON within And SearchResponseConversionTest ( will be new ) can reuse this to also assert the response conversion but get the query plan from the same place. |
expani
left a comment
There was a problem hiding this comment.
Thanks for the iterations @nssuresh2007 LGTM
|
Thanks @nssuresh2007 LGTM |
Signed-off-by: Suresh N S <nssuresh@amazon.com>
Signed-off-by: Suresh N S <nssuresh@amazon.com>
Signed-off-by: Suresh N S <nssuresh@amazon.com>
|
❌ Gradle check result for 1f07e44: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21227 +/- ##
============================================
- Coverage 73.42% 73.40% -0.02%
+ Complexity 74538 74518 -20
============================================
Files 5978 5978
Lines 338734 338734
Branches 48842 48842
============================================
- Hits 248709 248652 -57
- Misses 70180 70269 +89
+ Partials 19845 19813 -32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes to test the end to end DSL query conversion without OpenSearch cluster. Currently adds support for match_all and terms with agg for the initial commit.
Previous PR: #21060 (in feature/datafusion branch)
Description
This feature introduces a golden-file-based unit test framework for the OpenSearch DSL query executor plugin (
sandbox/plugins/dsl-query-executor/). The framework validates the correctness of both the forward conversion path (DSL → RelNode) and the reverse conversion path (RelNode execution results → SearchResponse DSL output) by comparing actual outputs against pre-approved golden files. Each golden file encodes a complete test case: the input DSL, the expected RelNode logical plan, simulated execution rows, and the expected DSL output.Requirements
Related Issues
Resolves #21429
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.