fix (ae): add scalars for IS_{bool}#22091
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
PR Reviewer Guide 🔍(Review updated until commit 50b9541)Here are some key observations to aid the review process:
|
IS_BOOL
IS_BOOLIS_{bool}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22091 +/- ##
============================================
+ Coverage 73.38% 73.40% +0.02%
- Complexity 75601 75667 +66
============================================
Files 6041 6041
Lines 343397 343420 +23
Branches 49420 49428 +8
============================================
+ Hits 252006 252099 +93
+ Misses 71266 71216 -50
+ Partials 20125 20105 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
|
Persistent review updated to latest commit 86e2c1d |
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
❌ Gradle check result for 86e2c1d: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 5c58a4d |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
|
Persistent review updated to latest commit 50b9541 |
* fix: add scalars for is with bool Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * add some test queries Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * also add is_true/etc as project functions Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Description
Quick fix in AE branch for CASE tests, some missing scalar functions
Related Issues
related: opensearch-project/sql#5531 (not blocking)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.