Skip to content

fix (ae): add scalars for IS_{bool} #22091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mch2 merged 4 commits into from
Jun 11, 2026
Merged

fix (ae): add scalars for IS_{bool} #22091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f87c887
fix: add scalars for is with bool
Swiddis Jun 9, 2026
86e2c1d
add some test queries
Swiddis Jun 10, 2026
5c58a4d
Merge branch 'main' into fix/case-tests
Swiddis Jun 11, 2026
50b9541
also add is_true/etc as project functions
Swiddis Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...x/libs/analytics-framework/src/main/java/org/opensearch/analytics/spi/ScalarFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ public enum ScalarFunction {
LESS_THAN_OR_EQUAL(Category.COMPARISON, SqlKind.LESS_THAN_OR_EQUAL),
IS_NULL(Category.COMPARISON, SqlKind.IS_NULL),
IS_NOT_NULL(Category.COMPARISON, SqlKind.IS_NOT_NULL),
IS_TRUE(Category.COMPARISON, SqlKind.IS_TRUE),
IS_FALSE(Category.COMPARISON, SqlKind.IS_FALSE),
IS_NOT_TRUE(Category.COMPARISON, SqlKind.IS_NOT_TRUE),
IS_NOT_FALSE(Category.COMPARISON, SqlKind.IS_NOT_FALSE),
IN(Category.COMPARISON, SqlKind.IN),
LIKE(Category.COMPARISON, SqlKind.LIKE),
PREFIX(Category.COMPARISON, SqlKind.OTHER_FUNCTION),
Expand Down
8 changes: 8 additions & 0 deletions ...tafusion/src/main/java/org/opensearch/be/datafusion/DataFusionAnalyticsBackendPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ public class DataFusionAnalyticsBackendPlugin implements AnalyticsSearchBackendP
ScalarFunction.LESS_THAN_OR_EQUAL,
ScalarFunction.IS_NULL,
ScalarFunction.IS_NOT_NULL,
ScalarFunction.IS_TRUE,
ScalarFunction.IS_FALSE,
ScalarFunction.IS_NOT_TRUE,
ScalarFunction.IS_NOT_FALSE,
ScalarFunction.IN,
ScalarFunction.LIKE,
ScalarFunction.REGEXP_CONTAINS,
Expand Down Expand Up @@ -146,6 +150,10 @@ public class DataFusionAnalyticsBackendPlugin implements AnalyticsSearchBackendP
ScalarFunction.IS_NULL,
ScalarFunction.IS_NOT_NULL,
ScalarFunction.NULLIF,
ScalarFunction.IS_TRUE,
ScalarFunction.IS_FALSE,
ScalarFunction.IS_NOT_TRUE,
ScalarFunction.IS_NOT_FALSE,
// ABS / SUBSTRING — PPL sort-pushdown moves these into the project tree; DataFusion has
// both natively and isthmus's default catalog binds them, so no adapter needed.
ScalarFunction.ABS,
Expand Down
1 change: 1 addition & 0 deletions sandbox/qa/analytics-engine-rest/src/test/resources/datasets/functions/ppl/q19.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
source=function_tests | where not true = case(amount > 0, true, amount < 0, false else false) | fields user, amount, status | head 10
1 change: 1 addition & 0 deletions sandbox/qa/analytics-engine-rest/src/test/resources/datasets/functions/ppl/q20.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
source=function_tests | where true = case(amount > 0, true else false) | fields user, amount | head 10
1 change: 1 addition & 0 deletions sandbox/qa/analytics-engine-rest/src/test/resources/datasets/functions/ppl/q21.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
source=function_tests | where false = case(amount > 0, true else false) | fields user, amount | head 10
1 change: 1 addition & 0 deletions sandbox/qa/analytics-engine-rest/src/test/resources/datasets/functions/ppl/q22.ppl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
source=function_tests | eval is_positive = case(amount > 0, true else false) | where not false = is_positive | fields user, amount, is_positive | head 10
Loading