Fixed DataFormatAwareDFASnapshotBlockingITs#22270
Draft
ask-kamal-nayan wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22270 +/- ##
============================================
+ Coverage 73.32% 73.34% +0.01%
- Complexity 75934 75990 +56
============================================
Files 6075 6075
Lines 345282 345327 +45
Branches 49697 49708 +11
============================================
+ Hits 253177 253278 +101
- Misses 71786 71843 +57
+ Partials 20319 20206 -113 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky DFA snapshot IT: add Lucene secondary format to hot index
DataFormatAwareDFASnapshotBlockingIT was failing with "timed out waiting for green state." The createHotDFAIndex helper created a composite index with
primary_data_format=parquet and no secondary format. Parquet alone can't provide the FULL_TEXT_SEARCH capability that the internal _field_names field
requires, so shard recovery failed (MapperParsingException) and the index never went green.
Fix: add secondary_data_formats=[lucene], matching the base class dfaIndexSettings() and every other DFA test.
Testing: All 3 tests pass with the original failing seed D3A2B9F9FDBA80FC (tests=3, failures=0, errors=0); compile + Spotless pass.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.