Skip to content

Fixed DataFormatAwareDFASnapshotBlockingITs#22270

Draft
ask-kamal-nayan wants to merge 1 commit into
opensearch-project:mainfrom
ask-kamal-nayan:snapshotflakytest
Draft

Fixed DataFormatAwareDFASnapshotBlockingITs#22270
ask-kamal-nayan wants to merge 1 commit into
opensearch-project:mainfrom
ask-kamal-nayan:snapshotflakytest

Conversation

@ask-kamal-nayan

Copy link
Copy Markdown
Contributor

Description

Fix flaky DFA snapshot IT: add Lucene secondary format to hot index

DataFormatAwareDFASnapshotBlockingIT was failing with "timed out waiting for green state." The createHotDFAIndex helper created a composite index with
primary_data_format=parquet and no secondary format. Parquet alone can't provide the FULL_TEXT_SEARCH capability that the internal _field_names field
requires, so shard recovery failed (MapperParsingException) and the index never went green.

Fix: add secondary_data_formats=[lucene], matching the base class dfaIndexSettings() and every other DFA test.

Testing: All 3 tests pass with the original failing seed D3A2B9F9FDBA80FC (tests=3, failures=0, errors=0); compile + Spotless pass.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kamal Nayan <askkamal@amazon.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

✅ Gradle check result for 2b70e6b: SUCCESS

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.34%. Comparing base (c73dc2e) to head (2b70e6b).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #22270      +/-   ##
============================================
+ Coverage     73.32%   73.34%   +0.01%     
- Complexity    75934    75990      +56     
============================================
  Files          6075     6075              
  Lines        345282   345327      +45     
  Branches      49697    49708      +11     
============================================
+ Hits         253177   253278     +101     
- Misses        71786    71843      +57     
+ Partials      20319    20206     -113     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant