Skip to content

Commit 069be4a

Browse files
committed
update function name to generateUuid()
Signed-off-by: Xun Zhang <xunzh@amazon.com>
1 parent a0960bd commit 069be4a

3 files changed

Lines changed: 17 additions & 16 deletions

File tree

data-prepper-expression/src/main/java/org/opensearch/dataprepper/expression/GenerateUuidExpressionFunction.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818

1919
/**
2020
* Expression function that generates a random UUID (version 4) string.
21-
* Usage: {@code generate_uuid()}
21+
* Usage: {@code generateUuid()}
2222
*/
2323
@Named
2424
public class GenerateUuidExpressionFunction implements ExpressionFunction {
2525

26-
static final String FUNCTION_NAME = "generate_uuid";
26+
static final String FUNCTION_NAME = "generateUuid";
2727

2828
@Override
2929
public String getFunctionName() {

data-prepper-expression/src/test/java/org/opensearch/dataprepper/expression/GenerateUuidExpressionFunctionTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import static org.hamcrest.CoreMatchers.not;
2222
import static org.hamcrest.CoreMatchers.equalTo;
2323
import static org.hamcrest.MatcherAssert.assertThat;
24+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
2425
import static org.junit.jupiter.api.Assertions.assertThrows;
2526
import static org.mockito.Mockito.mock;
2627

@@ -31,17 +32,17 @@ class GenerateUuidExpressionFunctionTest {
3132
private final Function<Object, Object> convertLiteralType = v -> v;
3233

3334
@Test
34-
void getFunctionName_returns_generate_uuid() {
35-
assertThat(function.getFunctionName(), equalTo("generate_uuid"));
35+
void getFunctionName_returns_generateUuid() {
36+
assertThat(function.getFunctionName(), equalTo("generateUuid"));
3637
}
3738

3839
@Test
3940
void evaluate_returns_valid_uuid_string() {
4041
final Object result = function.evaluate(Collections.emptyList(), event, convertLiteralType);
4142
assertThat(result, instanceOf(String.class));
4243
final String uuidStr = (String) result;
43-
// UUID.fromString throws if invalid
44-
assertThat(UUID.fromString(uuidStr).toString(), equalTo(uuidStr));
44+
final UUID regeneratedUuid = assertDoesNotThrow(() -> UUID.fromString(uuidStr));
45+
assertThat(regeneratedUuid.toString(), equalTo(uuidStr));
4546
}
4647

4748
@Test

data-prepper-plugins/mutate-event-processors/src/test/java/org/opensearch/dataprepper/plugins/processor/mutateevent/AddEntryProcessorTests.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,8 +1089,8 @@ public void testAddFlattenedNestedEntryIterateOn() {
10891089
}
10901090

10911091
@Test
1092-
void test_generate_uuid_expression_adds_uuid_string_to_event() {
1093-
final String uuidExpr = "generate_uuid()";
1092+
void test_generateUuid_expression_adds_uuid_string_to_event() {
1093+
final String uuidExpr = "generateUuid()";
10941094
final String generatedUuid = UUID.randomUUID().toString();
10951095
when(mockConfig.getEntries()).thenReturn(createListOfEntries(
10961096
createEntry("recordId", null, null, null, uuidExpr, false, false, null, null, null)));
@@ -1107,8 +1107,8 @@ void test_generate_uuid_expression_adds_uuid_string_to_event() {
11071107
}
11081108

11091109
@Test
1110-
void test_generate_uuid_expression_produces_unique_values_per_event() {
1111-
final String uuidExpr = "generate_uuid()";
1110+
void test_generateUuid_expression_produces_unique_values_per_event() {
1111+
final String uuidExpr = "generateUuid()";
11121112
final String uuid1 = UUID.randomUUID().toString();
11131113
final String uuid2 = UUID.randomUUID().toString();
11141114
when(mockConfig.getEntries()).thenReturn(createListOfEntries(
@@ -1128,8 +1128,8 @@ void test_generate_uuid_expression_produces_unique_values_per_event() {
11281128
}
11291129

11301130
@Test
1131-
void test_generate_uuid_expression_does_not_overwrite_existing_key_by_default() {
1132-
final String uuidExpr = "generate_uuid()";
1131+
void test_generateUuid_expression_does_not_overwrite_existing_key_by_default() {
1132+
final String uuidExpr = "generateUuid()";
11331133
when(mockConfig.getEntries()).thenReturn(createListOfEntries(
11341134
createEntry("existingId", null, null, null, uuidExpr, false, false, null, null, null)));
11351135
when(expressionEvaluator.isValidExpressionStatement(uuidExpr)).thenReturn(true);
@@ -1144,8 +1144,8 @@ void test_generate_uuid_expression_does_not_overwrite_existing_key_by_default()
11441144
}
11451145

11461146
@Test
1147-
void test_generate_uuid_expression_overwrites_existing_key_when_overwrite_is_true() {
1148-
final String uuidExpr = "generate_uuid()";
1147+
void test_generateUuid_expression_overwrites_existing_key_when_overwrite_is_true() {
1148+
final String uuidExpr = "generateUuid()";
11491149
final String newUuid = UUID.randomUUID().toString();
11501150
when(mockConfig.getEntries()).thenReturn(createListOfEntries(
11511151
createEntry("existingId", null, null, null, uuidExpr, true, false, null, null, null)));
@@ -1162,8 +1162,8 @@ void test_generate_uuid_expression_overwrites_existing_key_when_overwrite_is_tru
11621162
}
11631163

11641164
@Test
1165-
void test_generate_uuid_expression_respects_add_when_condition() {
1166-
final String uuidExpr = "generate_uuid()";
1165+
void test_generateUuid_expression_respects_add_when_condition() {
1166+
final String uuidExpr = "generateUuid()";
11671167
final String addWhen = "/skip == true";
11681168
when(mockConfig.getEntries()).thenReturn(createListOfEntries(
11691169
createEntry("recordId", null, null, null, uuidExpr, false, false, addWhen, null, null)));

0 commit comments

Comments
 (0)