Skip to content

Commit 0749be9

Browse files
author
Tomas Longo
committed
Remove todos
Signed-off-by: Tomas Longo <tomas.longo@sap.com>
1 parent a1c3d6c commit 0749be9

2 files changed

Lines changed: 0 additions & 10 deletions

File tree

data-prepper-plugins/otel-proto-common/src/test/java/org/opensearch/dataprepper/plugins/otel/codec/OTelProtoCodecTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -209,14 +209,6 @@ public void testParseExportTraceServiceRequest() throws IOException {
209209
validateSpans(spans);
210210
}
211211

212-
@Test
213-
// TODO tlongo is this test still relevant?
214-
public void testParseExportTraceServiceRequest_ScopeSpansTakesPrecedenceOverInstrumentationLibrarySpans() throws IOException {
215-
final ExportTraceServiceRequest exportTraceServiceRequest = buildExportTraceServiceRequestFromJsonFile(TEST_REQUEST_BOTH_SPAN_TYPES_JSON_FILE);
216-
final List<Span> spans = decoderUnderTest.parseExportTraceServiceRequest(exportTraceServiceRequest, Instant.now());
217-
validateSpans(spans);
218-
}
219-
220212
@Test
221213
public void testParseExportTraceServiceRequest_NoSpans() throws IOException {
222214
final ExportTraceServiceRequest exportTraceServiceRequest = buildExportTraceServiceRequestFromJsonFile(TEST_REQUEST_NO_SPANS_JSON_FILE);

data-prepper-plugins/otel-trace-source/src/main/java/org/opensearch/dataprepper/plugins/source/oteltrace/OTelTraceGrpcService.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ private void processRequest(final ExportTraceServiceRequest request, final Strea
9898
try {
9999
if (buffer.isByteBuffer()) {
100100
Map<String, ExportTraceServiceRequest> requestsMap = oTelProtoDecoder.splitExportTraceServiceRequestByTraceId(request);
101-
// TODO tlongo remove
102-
ExportTraceServiceRequest tmp;
103101
for (Map.Entry<String, ExportTraceServiceRequest> entry: requestsMap.entrySet()) {
104102
buffer.writeBytes(entry.getValue().toByteArray(), entry.getKey(), bufferWriteTimeoutInMillis);
105103
}

0 commit comments

Comments
 (0)