Skip to content

Commit 318483d

Browse files
authored
Using EventKey in Expression Parsing flow (#6064)
Using `EventKey` in `ParseTreeCoercionService` and corresponding test configuration fixes. It also includes change the data-prepper-event module classes to be moved from `org.opensearch.dataprepper.core.expression` to `org.opensearch.dataprepper.expression` and corresponding change in the Spring context initialization order.
1 parent aebb597 commit 318483d

35 files changed

Lines changed: 130 additions & 106 deletions

File tree

data-prepper-core/src/integrationTest/java/org/opensearch/dataprepper/plugin/DefaultPluginFactoryIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
import org.mockito.Mock;
1313
import org.mockito.junit.jupiter.MockitoExtension;
1414
import org.opensearch.dataprepper.core.acknowledgements.DefaultAcknowledgementSetManager;
15-
import org.opensearch.dataprepper.core.event.EventFactoryApplicationContextMarker;
1615
import org.opensearch.dataprepper.core.validation.LoggingPluginErrorsHandler;
1716
import org.opensearch.dataprepper.core.validation.PluginErrorCollector;
17+
import org.opensearch.dataprepper.event.EventFactoryApplicationContextMarker;
1818
import org.opensearch.dataprepper.metrics.PluginMetrics;
1919
import org.opensearch.dataprepper.model.configuration.PipelinesDataFlowModel;
2020
import org.opensearch.dataprepper.model.configuration.PluginSetting;

data-prepper-core/src/integrationTest/java/org/opensearch/dataprepper/plugins/ExtensionsIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import org.mockito.junit.jupiter.MockitoExtension;
1717
import org.opensearch.dataprepper.core.acknowledgements.DefaultAcknowledgementSetManager;
1818
import org.opensearch.dataprepper.core.breaker.CircuitBreakerManager;
19-
import org.opensearch.dataprepper.core.event.EventFactoryApplicationContextMarker;
2019
import org.opensearch.dataprepper.core.parser.config.DataPrepperAppConfiguration;
2120
import org.opensearch.dataprepper.core.parser.config.FileStructurePathProvider;
2221
import org.opensearch.dataprepper.core.parser.config.PipelineParserConfiguration;
@@ -25,8 +24,8 @@
2524
import org.opensearch.dataprepper.core.sourcecoordination.SourceCoordinatorFactory;
2625
import org.opensearch.dataprepper.core.validation.LoggingPluginErrorsHandler;
2726
import org.opensearch.dataprepper.core.validation.PluginErrorCollector;
27+
import org.opensearch.dataprepper.event.EventFactoryApplicationContextMarker;
2828
import org.opensearch.dataprepper.expression.StartsWithExpressionFunction;
29-
import org.opensearch.dataprepper.validation.PluginErrorsHandler;
3029
import org.opensearch.dataprepper.model.acknowledgements.AcknowledgementSetManager;
3130
import org.opensearch.dataprepper.model.configuration.PluginSetting;
3231
import org.opensearch.dataprepper.model.event.EventFactory;
@@ -35,6 +34,7 @@
3534
import org.opensearch.dataprepper.plugin.ObjectMapperConfiguration;
3635
import org.opensearch.dataprepper.plugin.TestPluggableInterface;
3736
import org.opensearch.dataprepper.plugins.test.TestExtension;
37+
import org.opensearch.dataprepper.validation.PluginErrorsHandler;
3838
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
3939

4040
import java.util.ArrayList;

data-prepper-core/src/main/java/org/opensearch/dataprepper/AbstractContextManager.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ public abstract class AbstractContextManager {
2929
BASE_DATA_PREPPER_PACKAGE + ".core",
3030
BASE_DATA_PREPPER_PACKAGE + ".plugin"
3131
};
32-
private static final String EXPRESSION_PACKAGE = BASE_DATA_PREPPER_PACKAGE + ".expression";
32+
private static final String[] PRE_BASE_DATA_PREPPER_PACKAGES = {
33+
BASE_DATA_PREPPER_PACKAGE + ".event",
34+
BASE_DATA_PREPPER_PACKAGE + ".expression"
35+
};
3336

3437
private final AnnotationConfigApplicationContext publicApplicationContext;
3538
private final AnnotationConfigApplicationContext coreApplicationContext;
@@ -53,7 +56,7 @@ public DataPrepper getDataPrepperBean() {
5356
}
5457

5558
private void start() {
56-
publicApplicationContext.scan(EXPRESSION_PACKAGE);
59+
publicApplicationContext.scan(PRE_BASE_DATA_PREPPER_PACKAGES);
5760
preRefreshPublicApplicationContext(publicApplicationContext);
5861

5962
publicApplicationContext.refresh();

data-prepper-core/src/main/java/org/opensearch/dataprepper/core/parser/model/DataPrepperConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
import com.fasterxml.jackson.annotation.JsonProperty;
1212
import com.fasterxml.jackson.annotation.JsonSetter;
1313
import com.fasterxml.jackson.annotation.Nulls;
14-
import org.opensearch.dataprepper.core.event.EventConfiguration;
15-
import org.opensearch.dataprepper.core.event.EventConfigurationContainer;
1614
import org.opensearch.dataprepper.core.parser.config.MetricTagFilter;
1715
import org.opensearch.dataprepper.core.peerforwarder.PeerForwarderConfiguration;
1816
import org.opensearch.dataprepper.core.pipeline.PipelineShutdownOption;
17+
import org.opensearch.dataprepper.event.EventConfiguration;
18+
import org.opensearch.dataprepper.event.EventConfigurationContainer;
1919
import org.opensearch.dataprepper.model.configuration.PipelineExtensions;
2020
import org.opensearch.dataprepper.model.configuration.PluginModel;
2121
import org.opensearch.dataprepper.plugin.ExperimentalConfiguration;

data-prepper-core/src/test/java/org/opensearch/dataprepper/core/parser/PipelineTransformerTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,16 @@
2121
import org.opensearch.dataprepper.TestDataProvider;
2222
import org.opensearch.dataprepper.core.acknowledgements.DefaultAcknowledgementSetManager;
2323
import org.opensearch.dataprepper.core.breaker.CircuitBreakerManager;
24-
import org.opensearch.dataprepper.core.event.EventFactoryApplicationContextMarker;
2524
import org.opensearch.dataprepper.core.parser.model.DataPrepperConfiguration;
2625
import org.opensearch.dataprepper.core.peerforwarder.PeerForwarderConfiguration;
2726
import org.opensearch.dataprepper.core.peerforwarder.PeerForwarderProvider;
2827
import org.opensearch.dataprepper.core.peerforwarder.PeerForwarderReceiveBuffer;
29-
import org.opensearch.dataprepper.core.pipeline.Pipeline;
3028
import org.opensearch.dataprepper.core.pipeline.HeadlessPipelineSource;
29+
import org.opensearch.dataprepper.core.pipeline.Pipeline;
3130
import org.opensearch.dataprepper.core.pipeline.router.RouterFactory;
3231
import org.opensearch.dataprepper.core.sourcecoordination.SourceCoordinatorFactory;
3332
import org.opensearch.dataprepper.core.validation.PluginErrorCollector;
33+
import org.opensearch.dataprepper.event.EventFactoryApplicationContextMarker;
3434
import org.opensearch.dataprepper.expression.ExpressionEvaluator;
3535
import org.opensearch.dataprepper.model.breaker.CircuitBreaker;
3636
import org.opensearch.dataprepper.model.buffer.Buffer;
@@ -61,15 +61,15 @@
6161
import java.util.UUID;
6262
import java.util.stream.Stream;
6363

64-
import static org.hamcrest.CoreMatchers.sameInstance;
6564
import static org.hamcrest.CoreMatchers.equalTo;
6665
import static org.hamcrest.CoreMatchers.instanceOf;
6766
import static org.hamcrest.CoreMatchers.notNullValue;
67+
import static org.hamcrest.CoreMatchers.sameInstance;
6868
import static org.hamcrest.MatcherAssert.assertThat;
69-
import static org.junit.jupiter.api.Assertions.assertTrue;
7069
import static org.hamcrest.Matchers.hasKey;
7170
import static org.hamcrest.core.Is.is;
7271
import static org.junit.jupiter.api.Assertions.assertThrows;
72+
import static org.junit.jupiter.api.Assertions.assertTrue;
7373
import static org.mockito.ArgumentMatchers.anyString;
7474
import static org.mockito.Mockito.doNothing;
7575
import static org.mockito.Mockito.mock;

data-prepper-core/src/test/java/org/opensearch/dataprepper/core/peerforwarder/PeerForwarderAppConfigIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
99
import org.junit.jupiter.api.Test;
1010
import org.opensearch.dataprepper.core.acknowledgements.DefaultAcknowledgementSetManager;
11-
import org.opensearch.dataprepper.core.event.EventFactoryApplicationContextMarker;
1211
import org.opensearch.dataprepper.core.peerforwarder.discovery.DiscoveryMode;
12+
import org.opensearch.dataprepper.event.EventFactoryApplicationContextMarker;
1313
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
1414
import org.springframework.context.annotation.Bean;
1515
import org.springframework.context.annotation.Configuration;

data-prepper-event/src/main/java/org/opensearch/dataprepper/core/event/CachingEventKeyFactory.java renamed to data-prepper-event/src/main/java/org/opensearch/dataprepper/event/CachingEventKeyFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package org.opensearch.dataprepper.core.event;
6+
package org.opensearch.dataprepper.event;
77

88
import com.github.benmanes.caffeine.cache.Cache;
99
import com.github.benmanes.caffeine.cache.Caffeine;

data-prepper-event/src/main/java/org/opensearch/dataprepper/core/event/DefaultBaseEventBuilder.java renamed to data-prepper-event/src/main/java/org/opensearch/dataprepper/event/DefaultBaseEventBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package org.opensearch.dataprepper.core.event;
6+
package org.opensearch.dataprepper.event;
77

88
import org.opensearch.dataprepper.model.event.BaseEventBuilder;
99
import org.opensearch.dataprepper.model.event.DefaultEventMetadata;
1010
import org.opensearch.dataprepper.model.event.Event;
11-
import org.opensearch.dataprepper.model.event.EventMetadata;
1211
import org.opensearch.dataprepper.model.event.EventHandle;
12+
import org.opensearch.dataprepper.model.event.EventMetadata;
1313

1414
import java.time.Instant;
1515
import java.util.HashMap;

data-prepper-event/src/main/java/org/opensearch/dataprepper/core/event/DefaultEventBuilderFactory.java renamed to data-prepper-event/src/main/java/org/opensearch/dataprepper/event/DefaultEventBuilderFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package org.opensearch.dataprepper.core.event;
6+
package org.opensearch.dataprepper.event;
77

88
import org.opensearch.dataprepper.model.event.Event;
99
import org.opensearch.dataprepper.model.event.EventBuilder;

data-prepper-event/src/main/java/org/opensearch/dataprepper/core/event/DefaultEventFactory.java renamed to data-prepper-event/src/main/java/org/opensearch/dataprepper/event/DefaultEventFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package org.opensearch.dataprepper.core.event;
6+
package org.opensearch.dataprepper.event;
77

88
import org.opensearch.dataprepper.model.event.BaseEventBuilder;
99
import org.opensearch.dataprepper.model.event.Event;

0 commit comments

Comments
 (0)