Skip to content

Commit 5762fe2

Browse files
authored
Confluence polling check changing to greater than or equals (#5629)
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
1 parent 33adb5c commit 5762fe2

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

data-prepper-plugins/saas-source-plugins/confluence-source/src/main/java/org/opensearch/dataprepper/plugins/source/confluence/ConfluenceService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
import static org.opensearch.dataprepper.plugins.source.confluence.utils.CqlConstants.CONTENT_TYPE_IN;
4343
import static org.opensearch.dataprepper.plugins.source.confluence.utils.CqlConstants.CONTENT_TYPE_NOT_IN;
4444
import static org.opensearch.dataprepper.plugins.source.confluence.utils.CqlConstants.DELIMITER;
45-
import static org.opensearch.dataprepper.plugins.source.confluence.utils.CqlConstants.GREATER_THAN;
45+
import static org.opensearch.dataprepper.plugins.source.confluence.utils.CqlConstants.GREATER_THAN_OR_EQUALS;
4646
import static org.opensearch.dataprepper.plugins.source.confluence.utils.CqlConstants.PREFIX;
4747
import static org.opensearch.dataprepper.plugins.source.confluence.utils.CqlConstants.SPACE_IN;
4848
import static org.opensearch.dataprepper.plugins.source.confluence.utils.CqlConstants.SPACE_NOT_IN;
@@ -160,7 +160,7 @@ StringBuilder createContentFilterCriteria(ConfluenceSourceConfig configuration,
160160
}
161161

162162
String formattedTimeStamp = ts.atZone(this.confluenceServerZoneId).format(DateTimeFormatter.ofPattern(CQL_LAST_MODIFIED_DATE_FORMAT));
163-
StringBuilder cQl = new StringBuilder(LAST_MODIFIED + GREATER_THAN + "\"" + formattedTimeStamp + "\"");
163+
StringBuilder cQl = new StringBuilder(LAST_MODIFIED + GREATER_THAN_OR_EQUALS + "\"" + formattedTimeStamp + "\"");
164164
if (!CollectionUtils.isEmpty(ConfluenceConfigHelper.getSpacesNameIncludeFilter(configuration))) {
165165
cQl.append(SPACE_IN).append(ConfluenceConfigHelper.getSpacesNameIncludeFilter(configuration).stream()
166166
.collect(Collectors.joining(DELIMITER, PREFIX, SUFFIX)))

data-prepper-plugins/saas-source-plugins/confluence-source/src/main/java/org/opensearch/dataprepper/plugins/source/confluence/utils/CqlConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
package org.opensearch.dataprepper.plugins.source.confluence.utils;
1212

1313
public class CqlConstants {
14-
public static final String GREATER_THAN = ">";
14+
public static final String GREATER_THAN_OR_EQUALS = ">=";
1515
public static final String CLOSING_ROUND_BRACKET = ")";
1616

1717
public static final String SPACE_IN = " AND space in (";

data-prepper-plugins/saas-source-plugins/confluence-source/src/test/java/org/opensearch/dataprepper/plugins/source/confluence/ConfluenceServiceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
import static org.junit.jupiter.api.Assertions.assertEquals;
5555
import static org.junit.jupiter.api.Assertions.assertNotNull;
5656
import static org.junit.jupiter.api.Assertions.assertThrows;
57-
import static org.junit.jupiter.api.Assertions.assertTrue;
5857
import static org.mockito.ArgumentMatchers.any;
5958
import static org.mockito.ArgumentMatchers.anyInt;
6059
import static org.mockito.ArgumentMatchers.anyString;
@@ -291,7 +290,8 @@ public void testCreateContentFilterCriteria(String confluenceServerTimezone) thr
291290
.format(DateTimeFormatter.ofPattern(CQL_LAST_MODIFIED_DATE_FORMAT));
292291
StringBuilder contentFilterCriteria = confluenceService.createContentFilterCriteria(confluenceSourceConfig, pollingTime);
293292
assertNotNull(contentFilterCriteria);
294-
assertTrue(contentFilterCriteria.toString().contains(formattedZonedPollingTime));
293+
String cqlToAssert = "lastModified>=\"" + formattedZonedPollingTime + "\" order by lastModified";
294+
assertEquals(cqlToAssert, contentFilterCriteria.toString());
295295
}
296296

297297

0 commit comments

Comments
 (0)