Skip to content

Commit 6e9681a

Browse files
committed
add experimental to the S3 enrich processor
Signed-off-by: Xun Zhang <xunzh@amazon.com>
1 parent b92c00c commit 6e9681a

5 files changed

Lines changed: 8 additions & 19 deletions

File tree

data-prepper-api/src/main/java/org/opensearch/dataprepper/model/event/Event.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import com.fasterxml.jackson.databind.JsonNode;
1414

1515
import java.io.Serializable;
16+
import java.util.Collection;
1617
import java.util.List;
1718
import java.util.Map;
1819

@@ -155,9 +156,9 @@ public interface Event extends Serializable {
155156
* @param keys the list of keys to selectively merge
156157
* @throws IllegalArgumentException if the input event is not compatible to merge.
157158
* @throws UnsupportedOperationException if the current Event does not support merging.
158-
* @since 2.11
159+
* @since 2.15
159160
*/
160-
void merge(Event other, List<String> keys);
161+
void merge(Event other, Collection<String> keys);
161162

162163
/**
163164
* Generates a serialized Json string of the entire Event

data-prepper-api/src/main/java/org/opensearch/dataprepper/model/event/JacksonEvent.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import java.io.ObjectInputStream;
3333
import java.time.Instant;
3434
import java.util.ArrayList;
35+
import java.util.Collection;
3536
import java.util.Collections;
3637
import java.util.Deque;
3738
import java.util.HashMap;
@@ -447,7 +448,7 @@ public void merge(final Event other) {
447448
}
448449

449450
@Override
450-
public void merge(final Event other, final List<String> keys) {
451+
public void merge(final Event other, final Collection<String> keys) {
451452
if (keys == null || keys.isEmpty()) {
452453
throw new IllegalArgumentException("Keys list must not be null or empty for selective merge.");
453454
}

data-prepper-plugins/s3-enrich-processor/src/main/java/org/opensearch/dataprepper/plugins/s3_enrich/processor/S3EnrichProcessor.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import org.opensearch.dataprepper.metrics.PluginMetrics;
1818
import org.opensearch.dataprepper.model.annotations.DataPrepperPlugin;
1919
import org.opensearch.dataprepper.model.annotations.DataPrepperPluginConstructor;
20+
import org.opensearch.dataprepper.model.annotations.Experimental;
2021
import org.opensearch.dataprepper.model.codec.InputCodec;
2122
import org.opensearch.dataprepper.model.configuration.PluginModel;
2223
import org.opensearch.dataprepper.model.configuration.PluginSetting;
@@ -47,6 +48,7 @@
4748

4849
import static org.opensearch.dataprepper.logging.DataPrepperMarkers.NOISY;
4950

51+
@Experimental
5052
@DataPrepperPlugin(name = "s3_enrich", pluginType = Processor.class, pluginConfigurationType = S3EnrichProcessorConfig.class)
5153
public class S3EnrichProcessor extends AbstractProcessor<Record<Event>, Record<Event>> {
5254
private static final Logger LOG = LoggerFactory.getLogger(S3EnrichProcessor.class);
@@ -113,7 +115,6 @@ public S3EnrichProcessor(final S3EnrichProcessorConfig s3EnrichProcessorConfig,
113115

114116
@Override
115117
public Collection<Record<Event>> doExecute(Collection<Record<Event>> records) {
116-
LOG.info("S3EnricherProcessor processing {} records", records.size());
117118
List<Record<Event>> resultRecords = new ArrayList<>();
118119

119120
// Process new records

data-prepper-plugins/s3-enrich-processor/src/test/java/org/opensearch/dataprepper/s3_enricher/processor/S3EnricherProcessorTest.java

Lines changed: 0 additions & 14 deletions
This file was deleted.

data-prepper-plugins/s3-source/src/main/java/org/opensearch/dataprepper/plugins/source/s3/S3ScanService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public class S3ScanService {
5454
private final ExecutorService executorService;
5555
private final List<ScanObjectWorker> workers;
5656

57-
public S3ScanService(final S3SourceConfig s3SourceConfig,
57+
public S3ScanService(final S3SourceConfig s3SourceConfig,
5858
final S3ClientBuilderFactory s3ClientBuilderFactory,
5959
final S3ObjectHandler s3ObjectHandler,
6060
final BucketOwnerProvider bucketOwnerProvider,

0 commit comments

Comments
 (0)