Validate the aws config via the @AssertTrue pattern

Signed-off-by: huy pham <huyp@amazon.com>

Author: huypham612

data-prepper-plugins/otlp-sink/src/main/java/org/opensearch/dataprepper/plugins/sink/otlp/OtlpSink.java

@@ -49,8 +49,6 @@ public class OtlpSink extends AbstractSink<Record<Span>> {
     public OtlpSink(@Nonnull final AwsCredentialsSupplier awsCredentialsSupplier, @Nonnull final OtlpSinkConfig config, @Nonnull final PluginMetrics pluginMetrics, @Nonnull final PluginSetting pluginSetting) {
         super(pluginSetting);
 
-        config.validate();
-
         this.sinkMetrics = new OtlpSinkMetrics(pluginMetrics, pluginSetting);
         this.buffer = new OtlpSinkBuffer(awsCredentialsSupplier, config, sinkMetrics);
     }

data-prepper-plugins/otlp-sink/src/main/java/org/opensearch/dataprepper/plugins/sink/otlp/configuration/OtlpSinkConfig.java

@@ -6,6 +6,7 @@
 
 import com.fasterxml.jackson.annotation.JsonProperty;
 import jakarta.validation.Valid;
+import jakarta.validation.constraints.AssertTrue;
 import jakarta.validation.constraints.Min;
 import jakarta.validation.constraints.NotBlank;
 import lombok.Getter;
@@ -115,12 +116,9 @@ public String getStsExternalId() {
     /**
      * Validate the AWS configuration.
      * This method ensures breaking change in future release where non-AWS OTLP endpoints are supported.
-     *
-     * @throws IllegalArgumentException if the AWS configuration is invalid
      */
-    public void validate() {
-        if (awsConfig == null) {
-            throw new IllegalArgumentException("aws configuration is required");
-        }
+    @AssertTrue
+    boolean isAwsConfigValid() {
+        return awsConfig != null;
     }
 }

data-prepper-plugins/otlp-sink/src/test/java/org/opensearch/dataprepper/plugins/sink/otlp/OtlpSinkTest.java

@@ -4,10 +4,8 @@
  */
 package org.opensearch.dataprepper.plugins.sink.otlp;
 
-import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.function.Executable;
 import org.opensearch.dataprepper.aws.api.AwsCredentialsSupplier;
 import org.opensearch.dataprepper.metrics.PluginMetrics;
 import org.opensearch.dataprepper.model.configuration.PluginSetting;
@@ -23,7 +21,6 @@
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.mockito.Mockito.doThrow;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
@@ -70,23 +67,6 @@ void testInitialize_startsBuffer() {
         verify(mockBuffer).start();
     }
 
-    @Test
-    void testConstructor_throwsWhenAwsConfigIsMissing() {
-        doThrow(new IllegalArgumentException("aws configuration is required"))
-                .when(mockConfig).validate();
-
-        // Act & Assert
-        final Executable constructorCall = () ->
-                new OtlpSink(mockAwsCredSupplier, mockConfig, mockMetrics, mockSetting);
-
-        final IllegalArgumentException thrown = Assertions.assertThrows(
-                IllegalArgumentException.class,
-                constructorCall
-        );
-
-        Assertions.assertEquals("aws configuration is required", thrown.getMessage());
-    }
-
     @Test
     void testOutput_addsEveryRecordToBuffer() {
         // Arrange

data-prepper-plugins/otlp-sink/src/test/java/org/opensearch/dataprepper/plugins/sink/otlp/configuration/OtlpSinkConfigTest.java

@@ -21,8 +21,8 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.nullValue;
-import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -169,23 +169,22 @@ void testCustomThresholdAndRetries() throws Exception {
     }
 
     @Test
-    void testValidateAwsConfig_doesNotThrowWhenPresent() throws Exception {
+    void testIsAwsConfigValid_returnsTrue_whenPresent() throws Exception {
         final String yaml = String.join("\n",
                 "endpoint: \"" + EXPECTED_ENDPOINT + "\"",
                 "aws: {}"
         );
         final OtlpSinkConfig config = mapper.readValue(yaml, OtlpSinkConfig.class);
-        assertDoesNotThrow(config::validate);
+        assertTrue(config.isAwsConfigValid());
     }
 
     @Test
-    void testValidateAwsConfig_throwsException() throws Exception {
+    void testIsAwsConfigValid_returnsFalse_whenMissing() throws Exception {
         final String yaml = String.join("\n",
                 "endpoint: \"" + EXPECTED_ENDPOINT + "\""
         );
         final OtlpSinkConfig config = mapper.readValue(yaml, OtlpSinkConfig.class);
-
-        assertThrows(IllegalArgumentException.class, config::validate);
+        assertFalse(config.isAwsConfigValid());
     }
 
     @Test