Removed failing testcase and added other tests

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>

Author: kkondaka

data-prepper-plugins/sqs-sink/src/test/java/org/opensearch/dataprepper/plugins/sink/sqs/SqsSinkServiceTest.java

@@ -25,6 +25,7 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.times;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.CoreMatchers.not;
 import static org.mockito.ArgumentMatchers.anyString;
@@ -70,8 +71,6 @@ public class SqsSinkServiceTest {
     @Mock
     private PluginFactory pluginFactory;
     @Mock
-    private PluginSetting codecPluginSettings;
-    @Mock
     private SendMessageBatchResponse flushResponse;
     @Mock
     private EventHandle eventHandle;
@@ -109,7 +108,6 @@ private SqsSinkService createObjectUnderTest() {
     void setup() {
         sinkContext = mock(SinkContext.class);
         pluginFactory = mock(PluginFactory.class);
-        codecPluginSettings = mock(PluginSetting.class);
         when(sinkContext.getExcludeKeys()).thenReturn(null);
         when(sinkContext.getIncludeKeys()).thenReturn(null);
         when(sinkContext.getTagsTargetKey()).thenReturn(null);
@@ -302,6 +300,22 @@ void TestExecuteWithOneBatch_MultipleRetries(int numRecords) throws Exception {
         verify(eventHandle, times(numRecords)).release(true);
     }
 
+    @Test
+    void TestFiFoQWithInvalidDeDupIdExpression() {
+        when(expressionEvaluator.isValidFormatExpression(anyString())).thenReturn(false);
+        when (sqsSinkConfig.getQueueUrl()).thenReturn(queueUrl+".fifo");
+        when (sqsSinkConfig.getDeDuplicationId()).thenReturn(UUID.randomUUID().toString()+"${/id - }");
+        assertThrows(IllegalArgumentException.class, ()-> createObjectUnderTest());
+    }
+
+    @Test
+    void TestFiFoQWithInvalidGroupIdExpression() {
+        when(expressionEvaluator.isValidFormatExpression(anyString())).thenReturn(false);
+        when (sqsSinkConfig.getQueueUrl()).thenReturn(queueUrl+".fifo");
+        when (sqsSinkConfig.getGroupId()).thenReturn(UUID.randomUUID().toString()+"${/id - }");
+        assertThrows(IllegalArgumentException.class, ()-> createObjectUnderTest());
+    }
+
     @ParameterizedTest
     @ValueSource(ints = {10, 30, 50, 70})
     void TestWithOneBatch_SuccessfulFlushFiFoQDynamic(int numRecords) throws Exception {

data-prepper-plugins/sqs-sink/src/test/java/org/opensearch/dataprepper/plugins/sink/sqs/SqsSinkTest.java

@@ -127,33 +127,6 @@ void TestBasic() {
         }
     }
 
-    @Test
-    void TestWithDLQConfig() {
-        PluginModel dlqConfig = mock(PluginModel.class);
-        when(dlqConfig.getPluginSettings()).thenReturn(new HashMap<String, Object>());
-        when(dlqConfig.getPluginName()).thenReturn("s3");
-
-        S3DlqWriterConfig s3DlqWriterConfig = mock(S3DlqWriterConfig.class);
-        when(s3DlqWriterConfig.getBucket()).thenReturn("bucket");
-        when(s3DlqWriterConfig.getKeyPathPrefix()).thenReturn("dlq");
-        S3Client s3Client = mock(S3Client.class);
-        when(s3DlqWriterConfig.getS3Client()).thenReturn(s3Client);
-        S3DlqProvider s3DlqProvider = new S3DlqProvider(s3DlqWriterConfig);
-        when(pluginFactory.loadPlugin(eq(DlqProvider.class), any())).thenReturn(s3DlqProvider);
-
-        when(sqsSinkConfig.getDlq()).thenReturn(dlqConfig);
-
-        try(MockedStatic<SqsClientFactory> mockedStatic = mockStatic(SqsClientFactory.class)) {
-            mockedStatic.when(() -> SqsClientFactory.createSqsClient(any(Region.class),
-                            any(AwsCredentialsProvider.class)))
-                    .thenReturn(sqsClient);
-
-            SqsSink sqsSink = createObjectUnderTest();
-            sqsSink.doInitialize();
-            assertTrue(sqsSink.isReady());
-        }
-    }
-
     @Test
     void TestWithInvalidCodec() {
         when(codecConfig.getPluginName()).thenReturn("badCodec");