feat(expression): add subList function and standardize argument validation#5588
Open
saketh-pallempati wants to merge 3 commits into
Open
feat(expression): add subList function and standardize argument validation#5588saketh-pallempati wants to merge 3 commits into
saketh-pallempati wants to merge 3 commits into
Conversation
…ation - Introduced SubListExpressionFunction to support extracting a sublist from an event field. - Modified function argument handling to accept integer types directly. - Updated all expression functions to throw IllegalArgumentException for invalid arguments. - Moved granular type-checking and argument validation responsibilities to individual functions, simplifying the parser and evaluator logic. Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
saketh-pallempati
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Contributor
Author
|
I will raise the documentation issue if the changes are considered by the team. |
To solve the flaky TimeZoneHelper utility and corresponding test case
dlvenable
requested changes
May 8, 2025
Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
Contributor
Author
|
Hi @dlvenable I made the changes required. Please do check and let me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SubListExpressionFunctionto support extracting a sublist from an event field.IllegalArgumentExceptionfor invalid arguments.Issues Resolved
Resolves #5529
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.