Skip to content

Fix EventType in Rds source#5598

Merged
oeyh merged 1 commit into
opensearch-project:mainfrom
oeyh:rds/gameday-findings
Apr 14, 2025
Merged

Fix EventType in Rds source#5598
oeyh merged 1 commit into
opensearch-project:mainfrom
oeyh:rds/gameday-findings

Conversation

@oeyh
Copy link
Copy Markdown
Collaborator

@oeyh oeyh commented Apr 14, 2025

Description

This PR fixes a few things in Rds source plugin:

  • Populate correct stream event type (insert/update/delete) in event metadata
  • Name export role more explicitly
  • Add NOISY markers to a few more places
  • Fixes an issue with empty s3 prefix causing invalidate prefix error in RDS export (prefix cannot start with "/")

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@oeyh
Fix EventType and a few other things
837de58 
Signed-off-by: Hai Yan <oeyh@amazon.com>
@oeyh oeyh merged commit 9a4628b into opensearch-project:main Apr 14, 2025
46 of 47 checks passed
amdhing pushed a commit to amdhing/data-prepper that referenced this pull request Apr 16, 2025
@oeyh
Fix EventType and a few other things (opensearch-project#5598)
f7fae29 
Signed-off-by: Hai Yan <oeyh@amazon.com>
Davidding4718 pushed a commit to Davidding4718/data-prepper that referenced this pull request Apr 25, 2025
@oeyh @Galactus22625
Fix EventType and a few other things (opensearch-project#5598)
83c4d59 
Signed-off-by: Hai Yan <oeyh@amazon.com>
Davidding4718 pushed a commit to Davidding4718/data-prepper that referenced this pull request Apr 25, 2025
@oeyh @Davidding4718
Fix EventType and a few other things (opensearch-project#5598)
a27ae7f 
Signed-off-by: Hai Yan <oeyh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divbok divbok divbok approved these changes

@chenqi0805 chenqi0805 chenqi0805 approved these changes

@sb2k16 sb2k16 Awaiting requested review from sb2k16 sb2k16 is a code owner

@engechas engechas Awaiting requested review from engechas

@san81 san81 Awaiting requested review from san81 san81 is a code owner

@srikanthjg srikanthjg Awaiting requested review from srikanthjg srikanthjg is a code owner

@graytaylor0 graytaylor0 Awaiting requested review from graytaylor0 graytaylor0 is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka is a code owner

@KarstenSchnitter KarstenSchnitter Awaiting requested review from KarstenSchnitter KarstenSchnitter is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oeyh @divbok @chenqi0805