Few updates to RDS source plugin#5602
Merged
Merged
Conversation
Signed-off-by: Hai Yan <oeyh@amazon.com>
Signed-off-by: Hai Yan <oeyh@amazon.com>
Signed-off-by: Hai Yan <oeyh@amazon.com>
oeyh
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
san81,
sb2k16 and
srikanthjg
as code owners
divbok
approved these changes
Apr 15, 2025
dinujoh
reviewed
Apr 16, 2025
| shutdownRequested = true; | ||
|
|
||
| // Clean up publication and replication slot for Postgres | ||
| if (streamPartition != null) { |
Member
There was a problem hiding this comment.
How do you plan to clean up long term when the RDS source is deleted ?
Collaborator
Author
There was a problem hiding this comment.
I don't have a good plan on this yet. We can discuss this offline.
dinujoh
reviewed
Apr 16, 2025
Comment on lines
+51
to
+52
| @NotEmpty | ||
| private String database; |
Member
There was a problem hiding this comment.
Is this change made because we don't support the use case of table join across database ?
Collaborator
Author
There was a problem hiding this comment.
The change in this PR is just moving the option out of TableFilterConfig, it was added in a previous PR. And yes, the database option is to limit the range of tables within one database. We don't support cross database in a single pipeline.
dinujoh
approved these changes
Apr 16, 2025
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
* Remove step to clean up replication slot Signed-off-by: Hai Yan <oeyh@amazon.com> * Update table filter config Signed-off-by: Hai Yan <oeyh@amazon.com> * Fix query for mysql 8.4 Signed-off-by: Hai Yan <oeyh@amazon.com> --------- Signed-off-by: Hai Yan <oeyh@amazon.com>
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
* Remove step to clean up replication slot Signed-off-by: Hai Yan <oeyh@amazon.com> * Update table filter config Signed-off-by: Hai Yan <oeyh@amazon.com> * Fix query for mysql 8.4 Signed-off-by: Hai Yan <oeyh@amazon.com> --------- Signed-off-by: Hai Yan <oeyh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a few more changes to rds source plugin:
databaseoption out of table filter configgetCurrentBinaryLogPosition()method so it's compatible with MySQL version 8.4 and later.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.