Atlassian Jira Gameday fixes#5603
Merged
Merged
Conversation
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
san81
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
sb2k16 and
srikanthjg
as code owners
dinujoh
approved these changes
Apr 16, 2025
oeyh
approved these changes
Apr 16, 2025
| boolean isValidPageType() { | ||
| return checkGivenListForValidPageTypes(include) | ||
| && checkGivenListForValidPageTypes(exclude) | ||
| && noOverlapBetweenIncludeAndExclude(); |
Collaborator
There was a problem hiding this comment.
Nit: this noOverlapBetweenIncludeAndExclude() doesn't seem necessary here since there's a separate validation for it just below this. It also doesn't match the error message here.
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
* regex fix for having multiple values in the cql filter Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com> * validations fixes for the page type and space key Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com> * Adding event metadata so that it can be used in dynamic index name Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com> --------- Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
* regex fix for having multiple values in the cql filter Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com> * validations fixes for the page type and space key Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com> * Adding event metadata so that it can be used in dynamic index name Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com> --------- Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.