Initial commit for CrowdStrike source crawler#5619
Merged
Conversation
nsgupta1
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
eirsep
reviewed
Apr 17, 2025
| /** | ||
| * Batch size for fetching Threat Intel Feeds | ||
| */ | ||
| private static final int DEFAULT_BATCH_SIZE = 10000; |
Member
There was a problem hiding this comment.
nit: DEFAULT_IOC_FETCH_BATCH_SIZE
Signed-off-by: ngsupta1 <guptaneha.e@gmail.com>
Signed-off-by: ngsupta1 <guptaneha.e@gmail.com>
Signed-off-by: ngsupta1 <guptaneha.e@gmail.com>
nsgupta1
commented
Apr 18, 2025
| public void start(Buffer<Record<Event>> buffer) { | ||
| log.info("Starting CrowdStrike Source Plugin..."); | ||
| authClient.initCredentials(); | ||
| // super.start(buffer); |
Contributor
Author
Signed-off-by: nsgupta1 <nsgupta1@users.noreply.github.com>
san81
reviewed
Apr 18, 2025
| * @throws RuntimeException if the token cannot be retrieved. | ||
| */ | ||
| private void getAuthToken() { | ||
| log.info(NOISY, "You are trying to access token"); |
Collaborator
There was a problem hiding this comment.
When token expired, you probably don't want every worker to renew it. Think about handling that when you wire this method into the renewal flow
Contributor
Author
There was a problem hiding this comment.
ack !! I will include refresh mechanism in next PR.
san81
reviewed
Apr 18, 2025
| this.expireTime = Instant.now().plusSeconds((Integer) tokenData.get(EXPIRE_IN)); | ||
| log.info("Access token acquired successfully"); | ||
| } catch (HttpClientErrorException ex) { | ||
| this.expireTime = Instant.ofEpochMilli(0); |
Collaborator
There was a problem hiding this comment.
Think about the retry strategy here in your next pr
Contributor
Author
There was a problem hiding this comment.
ack !! I will include retry mechanism in next PR.
san81
approved these changes
Apr 18, 2025
srikanthjg
approved these changes
Apr 18, 2025
engechas
approved these changes
Apr 18, 2025
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
* Initial commit for CrowdStrike source crawler Signed-off-by: nsgupta1 <nsgupta1@users.noreply.github.com> --------- Signed-off-by: ngsupta1 <guptaneha.e@gmail.com> Signed-off-by: nsgupta1 <nsgupta1@users.noreply.github.com> Co-authored-by: nsgupta1 <nsgupta1@users.noreply.github.com>
Davidding4718
pushed a commit
to Davidding4718/data-prepper
that referenced
this pull request
Apr 25, 2025
* Initial commit for CrowdStrike source crawler Signed-off-by: nsgupta1 <nsgupta1@users.noreply.github.com> --------- Signed-off-by: ngsupta1 <guptaneha.e@gmail.com> Signed-off-by: nsgupta1 <nsgupta1@users.noreply.github.com> Co-authored-by: nsgupta1 <nsgupta1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Introducing new saas crawler for CrowdStrike Falcon API]
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.