Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1fc9a60
Feature/xray init (#1)
huypham612 Apr 3, 2025
5978b82
Add a simple integration-test (#2)
huypham612 Apr 3, 2025
e57e574
Add X-Ray OTLP sink configuration and tests (#5)
geekgirl10 Apr 3, 2025
e992cf6
feature/sigv4: Add SigV4 signer and encapsulate AWS config (#6)
huypham612 Apr 9, 2025
64df871
Add otlp proto trace output codec (#8)
geekgirl10 Apr 11, 2025
4cf85ee
Add XRayOTLPSink and XRayOtlpHttpSender for sending OTLP trace data t…
geekgirl10 Apr 12, 2025
fb080cc
feat(otlp-sink): Add retry, batching, OkHttp client, and encoder refa…
huypham612 Apr 14, 2025
6e732ba
feature: Add PluginMetrics instrumentation for OTLP delivery and thro…
huypham612 Apr 16, 2025
7dadd57
fix: use Timer to track latency metrics and correcting latency metric…
huypham612 Apr 17, 2025
4608a77
feature: add gzip and percentile metrics (#13)
huypham612 Apr 23, 2025
e876183
feature(threshold-config): add threshold configuration support (#14)
huypham612 Apr 29, 2025
28bd811
refactor(aws-region): get aws region from endpoint value
huypham612 Apr 30, 2025
e85cd1c
refactor(http-retry-code): follow retryable code
huypham612 Apr 30, 2025
3477932
refactor(log/exception): only use log.error
huypham612 Apr 30, 2025
6506627
fix(otlp-sink-buffer): Ensure final flush drains queue on shutdown
huypham612 Apr 30, 2025
242ca15
Update README
huypham612 Apr 30, 2025
390f951
Removed unused Output codec
huypham612 Apr 30, 2025
01671b1
Update OTLP sink with Armeria, metrics, buffering, and config improve…
huypham612 May 15, 2025
2728591
Release EventHandle on both success and failure; switch to AwsCredent…
huypham612 May 22, 2025
977b524
Avoid breaking change by making the aws config block required.
huypham612 May 23, 2025
bb4ffb0
Validate the aws config via the @AssertTrue pattern
huypham612 May 23, 2025
01851ea
Add missing unit test to reach 100%
huypham612 May 30, 2025
af11f60
Resolve merge conflicts with upstream main
huypham612 May 30, 2025
8527a38
Mock AWS credentials provider to allow tests to run without real cred…
huypham612 May 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
176 changes: 176 additions & 0 deletions data-prepper-plugins/otlp-sink/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
# OTLP Sink Plugin

The OTLP sink plugin sends span data using the OpenTelemetry Protocol (OTLP) format.
The initial release supports exporting spans to AWS X-Ray. Future releases will support sending spans, metrics, and logs
to any OTLP Protobuf-compatible endpoint.
Comment thread
huypham612 marked this conversation as resolved.

---

## Known Limitations

- Currently, supports only trace data (spans). Support for metrics and logs will be added in future releases.
- No support for DQL-based loss-less delivery in this release.
- Only AWS X-Ray-compatible OTLP endpoints are currently supported (`https://xray.<region>.amazonaws.com/v1/traces`).
Comment thread
huypham612 marked this conversation as resolved.
- Only OTLP over HTTP is supported; gRPC is not yet supported.

---

## Sample Pipeline Configuration

### Minimal Configuration (No STS)

Use this when Data Prepper has permission to write to AWS X-Ray directly.

```yaml
otlp_pipeline:
source:
otel_trace_source:

sink:
- otlp:
endpoint: "https://xray.us-west-2.amazonaws.com/v1/traces"
aws: { }
```

### Full Configuration with STS

Use this when assuming a cross-account role is required.

```yaml
otlp_pipeline:
workers: 2

source:
otel_trace_source:
ssl: false
port: 21890

buffer:
bounded_blocking:
buffer_size: 1000000
batch_size: 125000

sink:
- otlp:
endpoint: "https://xray.us-west-2.amazonaws.com/v1/traces"
max_retries: 5
threshold:
max_events: 512
max_batch_size: 1mb
flush_timeout: 200ms
aws:
sts_role_arn: arn:aws:iam::123456789012:role/MyRole
sts_external_id: external-id-value
```

---

## Configuration Options

| Property | Type | Required | Default | Description |
|----------------------------|----------|----------|-----------------------|----------------------------------------------------------------------------------------------------------|
| `endpoint` | `String` | Yes | — | AWS X-Ray OTLP endpoint where spans will be sent. |
| `max_retries` | `int` | No | `5` | Maximum number of retry attempts on HTTP send failures. |
| **threshold** | `Object` | No | — | Controls batching behavior. See below for sub-properties. |
| `threshold.max_events` | `int` | No | `512` (recommended) | Maximum number of spans per batch. Use `0` to disable count-based flushing. Must be ≥ 0. |
| `threshold.max_batch_size` | `String` | No | `1mb` (recommended) | Maximum total payload bytes per batch. Supports human-readable suffixes (`kb`, `mb`). |
| `threshold.flush_timeout` | `String` | No | `200ms` (recommended) | Maximum time to wait before flushing a non-empty batch. Minimum: 1ms (e.g., `200ms`, `1s`) |
| **aws** | `Object` | Yes | — | AWS authentication settings. Use `{}` if no STS role is needed. See below. |
| `aws.sts_role_arn` | `String` | No | — | IAM Role ARN that Data Prepper (or OSI) assumes to send spans to X-Ray on behalf of a customer account. |
| `aws.sts_external_id` | `String` | No | — | External ID to use when assuming the role. Required only if the target IAM role enforces sts:ExternalId. |

**Additional Notes:**

- `aws.region` is automatically derived from the endpoint.

---

## Performance Benchmark

### Summary

* Sustains ~3.5K TPS with ≤150ms p99 latency on t4g.large.
Comment thread
huypham612 marked this conversation as resolved.
* Uses only ~8% CPU, ~100MB heap.
* 0 errors, retries, or drops during a 3-hour soak test.

### Tuning Recommendations

| Setting | Recommended | Reason |
|------------------|-------------|-------------------------------------------------------------------------------------------------|
| `max_retries` | `5` | Matches AWS SDK default. Gives ~8s of exponential backoff to tolerate transient 503/5xx errors. |
| `max_events` | `512` | Supports up to 3.5K TPS with 2 workers. Keeps p99 latency around 130ms. |
| `max_batch_size` | `1mb` | Aligns with OTEL + AWS X-Ray guidance. Larger batches get split, increasing latency/load. |
| `flush_timeout` | `200ms` | Short enough to avoid delay, long enough to fill batches and keep CPU/GCs low. |

### Additional Tuning tips

* Lower `max_events` to **200–400** to reduce latency below 100 ms
* Decrease `flush_timeout` to **100 ms** for faster flushes (with higher CPU/network cost)
* Increase `max_batch_size` to **≥ 8 MB** only if p99 span > 9 KB
* Add pipeline workers if queue saturates at >4K TPS

### Queue Sizing Rule

> Queue capacity = max_events * 10 (minimum 2000)
>
> To keep memory usage under ~50MB:
> max_events ≤ 50_000_000 ÷ (10 × p99_span_size_bytes)
>
> Example: With p99 span size of 1 KB, max_events should be ≤ 5000


---

## Protocol Details

* Protocol: OTLP over HTTP
* Content-Type: `application/x-protobuf`
* Compression: `gzip` (enabled by default)
All outgoing HTTP requests use gzip compression to reduce payload size and bandwidth usage.

---

## Delivery Semantics

Currently, the sink provides at-most-once delivery. Once retries are exhausted, span batches are dropped.
Future releases will support durable queueing via DQL for loss-less guarantees.

---

## Retry Behavior

- The sink uses an exponential backoff with jitter strategy for retryable HTTP status codes (e.g., 429, 502, 503, 504).
- Maximum number of attempts is controlled by `max_retries`. Once exceeded:
- The span batch is dropped.
- The plugin logs the exception and increments the error metric.
- Non-retryable errors (e.g., 400, 403) are logged and counted immediately without retry.
- Retry logic follows
the [OTLP/HTTP response specification](https://opentelemetry.io/docs/specs/otlp/#otlphttp-response).
- `Retry-After` header is not used for dynamic backoff because:
- Armeria’s retry rule API only supports boolean conditions or fixed `Backoff` strategies.
- Supporting `Retry-After` would require a custom `Backoff` implementation, adding unnecessary complexity.
- The exponential backoff already handles common retry intervals effectively.
---

## Logging & Metrics

* Exceptions are logged with full stack traces. No customer data is logged.
* Metrics are emitted via Micrometer and include:
* recordsIn, recordsOut
* httpLatency, HTTP codes
* errorCount, rejectedSpansCount, failedSpansCount, retriesCount
* queueSize, queueCapacity
* payloadSize, payloadGzipSize
* JVM stats if configured (e.g., heap usage, GC pauses)

---

## Developer Guide

See the [CONTRIBUTING](https://github.com/opensearch-project/data-prepper/blob/main/CONTRIBUTING.md) guide for general information on contributions.

### Run unit tests locally

```bash
./gradlew :data-prepper-plugins:otlp-sink:test
```
88 changes: 88 additions & 0 deletions data-prepper-plugins/otlp-sink/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

sourceSets {
integrationTest {
java.srcDir file('src/integrationTest/java')
resources.srcDir file('src/integrationTest/resources')
compileClasspath += sourceSets.main.output
runtimeClasspath += sourceSets.main.output
}
}

configurations {
integrationTestImplementation.extendsFrom testImplementation
integrationTestRuntimeOnly.extendsFrom testRuntimeOnly
}

dependencies {
// AWS SDK
implementation 'software.amazon.awssdk:sdk-core'
implementation 'software.amazon.awssdk:auth'
implementation 'software.amazon.awssdk:sts'
implementation 'software.amazon.awssdk:regions'
implementation 'software.amazon.awssdk:http-client-spi'
implementation 'software.amazon.awssdk:apache-client'

// Hibernate
implementation 'org.hibernate.validator:hibernate-validator:8.0.1.Final'

// OpenTelemetry Protobuf
implementation libs.opentelemetry.proto
implementation libs.protobuf.util
testImplementation libs.opentelemetry.proto
testImplementation libs.protobuf.util

// Jackson
implementation 'com.fasterxml.jackson.core:jackson-databind'
implementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml'
testImplementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml'

// Lombok
compileOnly 'org.projectlombok:lombok:1.18.30'
annotationProcessor 'org.projectlombok:lombok:1.18.30'

// Data Prepper Projects
implementation project(':data-prepper-api')
implementation project(':data-prepper-plugins:aws-plugin-api')
implementation project(':data-prepper-plugins:otel-proto-common')

// Armeria
implementation libs.armeria.core

// Metrics
implementation 'io.micrometer:micrometer-core'
}

test {
useJUnitPlatform()
finalizedBy jacocoTestReport, jacocoTestCoverageVerification
}

tasks.register('integrationTest', Test) {
description = 'Runs integration tests.'
group = 'verification'
testClassesDirs = sourceSets.integrationTest.output.classesDirs
classpath = sourceSets.integrationTest.runtimeClasspath
shouldRunAfter test
useJUnitPlatform()
}

check.dependsOn integrationTest

jacocoTestCoverageVerification {
violationRules {
rule {
enabled = true
element = 'CLASS'
includes = ['org.opensearch.dataprepper.plugins.sink.otlp.*']
limit {
counter = 'LINE'
value = 'COVEREDRATIO'
minimum = 1.00
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

package org.opensearch.dataprepper.plugins.sink.otlp;

import org.opensearch.dataprepper.aws.api.AwsCredentialsSupplier;
import org.opensearch.dataprepper.metrics.PluginMetrics;
import org.opensearch.dataprepper.model.annotations.DataPrepperPlugin;
import org.opensearch.dataprepper.model.annotations.DataPrepperPluginConstructor;
import org.opensearch.dataprepper.model.annotations.Experimental;
import org.opensearch.dataprepper.model.configuration.PluginSetting;
import org.opensearch.dataprepper.model.record.Record;
import org.opensearch.dataprepper.model.sink.AbstractSink;
import org.opensearch.dataprepper.model.sink.Sink;
import org.opensearch.dataprepper.model.trace.Span;
import org.opensearch.dataprepper.plugins.sink.otlp.buffer.OtlpSinkBuffer;
import org.opensearch.dataprepper.plugins.sink.otlp.configuration.OtlpSinkConfig;
import org.opensearch.dataprepper.plugins.sink.otlp.metrics.OtlpSinkMetrics;

import javax.annotation.Nonnull;
import java.util.Collection;

/**
* OTLP Sink Plugin for Data Prepper.
*/
@Experimental
@DataPrepperPlugin(
Comment thread
huypham612 marked this conversation as resolved.
name = "otlp",
pluginType = Sink.class,
pluginConfigurationType = OtlpSinkConfig.class
)
public class OtlpSink extends AbstractSink<Record<Span>> {
private volatile boolean initialized = false;

private final OtlpSinkBuffer buffer;
private final OtlpSinkMetrics sinkMetrics;

/**
* Constructor for the OTLP sink plugin.
*
* @param awsCredentialsSupplier the AWS credentials supplier
* @param config the configuration for the sink
* @param pluginMetrics the plugin metrics to use
* @param pluginSetting the plugin setting to use
*/
@DataPrepperPluginConstructor
public OtlpSink(@Nonnull final AwsCredentialsSupplier awsCredentialsSupplier, @Nonnull final OtlpSinkConfig config, @Nonnull final PluginMetrics pluginMetrics, @Nonnull final PluginSetting pluginSetting) {
super(pluginSetting);

this.sinkMetrics = new OtlpSinkMetrics(pluginMetrics, pluginSetting);
this.buffer = new OtlpSinkBuffer(awsCredentialsSupplier, config, sinkMetrics);
}

/**
* Initialize the buffer
*/
@Override
public void doInitialize() {
buffer.start();
initialized = true;
}

/**
* Implement the sink's output logic
*
* @param records Records to be output
*/
@Override
public void doOutput(@Nonnull final Collection<Record<Span>> records) {
for (final Record<Span> record : records) {
buffer.add(record);
}
}

/**
* Indicates whether this sink is ready to receive data.
*
* @return true if the sink is ready
*/
@Override
public boolean isReady() {
return initialized && buffer.isRunning();
}

/**
* Hook called during pipeline shutdown.
*/
@Override
public void shutdown() {
super.shutdown();
buffer.stop();
}
}
Loading
Loading