Skip to content

Fix validation for default route #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graytaylor0 merged 1 commit into from
May 6, 2025
Merged

Fix validation for default route #5682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...t/resources/org/opensearch/dataprepper/pipeline/route/three-route-with-default-route.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ routing-pipeline:
- alpha: '/value == "a"'
- beta: '/value == "b"'
- gamma: '/value == "g"'
- _default: '/_default == "z"'
sink:
- in_memory:
testing_key: ConditionalRoutingIT_alpha
Expand Down
3 changes: 3 additions & 0 deletions .../main/java/org/opensearch/dataprepper/pipeline/parser/PipelineConfigurationValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public class PipelineConfigurationValidator {
private static final String PIPELINE_TYPE = "pipeline";
private static final Set<String> INVALID_PIPELINE_NAMES = new HashSet<>(List.of("data-prepper", "dataPrepper", "core"));

private static final String DEFAULT_ROUTE = "_default";

/**
* Sorts the pipelines in topological order while also validating for
* i. cycles in pipeline configuration
Expand Down Expand Up @@ -199,6 +201,7 @@ private static void validateSinkRoutes(final Map<String, PipelineConfiguration>
}
List<String> invalidRoutes = sinkRoutes.stream()
.filter(route -> !validRoutes.contains(route))
.filter(route -> !route.equals(DEFAULT_ROUTE))
.collect(Collectors.toList());

if (!invalidRoutes.isEmpty()) {
Expand Down