Increase Sqs sink test coverage. Add more metrics#5693
Merged
Conversation
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
sb2k16
approved these changes
May 14, 2025
| fifoQueue = queueUrl.endsWith(SQS_FIFO_SUFFIX); | ||
| entries = new HashMap<>(); | ||
| currentBatchEntry = null; | ||
| currentId = null; |
Member
There was a problem hiding this comment.
could you please explain what is the purpose of this
Collaborator
Author
There was a problem hiding this comment.
It is used in deletion of messages.
oeyh
approved these changes
May 16, 2025
alparish
pushed a commit
to alparish/data-prepper
that referenced
this pull request
May 22, 2025
…#5693) Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tests to increase sqs sink test coverage to 0.99.
Added distribution summary metrics to capture request latency and request size
Fixed bugs
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.