Change replication slot naming in RDS source#5699
Merged
Merged
Conversation
Signed-off-by: Hai Yan <oeyh@amazon.com>
oeyh
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
san81,
sb2k16 and
srikanthjg
as code owners
divbok
approved these changes
May 16, 2025
divbok
reviewed
May 16, 2025
|
|
||
| private String generateReplicationSlotName() { | ||
| return "data_prepper_slot_" + UUID.randomUUID().toString().substring(0, 8); | ||
| private String generateReplicationSlotName(final String suffix) { |
Collaborator
There was a problem hiding this comment.
nit: Is there any restriction on the replication slot name length?
Collaborator
Author
There was a problem hiding this comment.
Length limit is 63 chars. The generated slot name is around 40-50 chars, so it's within range.
dinujoh
approved these changes
May 19, 2025
alparish
pushed a commit
to alparish/data-prepper
that referenced
this pull request
May 22, 2025
Signed-off-by: Hai Yan <oeyh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change replication slot naming in RDS source to include pipeline name so it's easier to identify the pipeline it associates with.
The replication slot name used to look like this:
data_prepper_xxxxxx.With this change, it will be:
data_prepper_pipeline_name_xxxxxx.Similar change was done for publication name.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.