Add STS header overrides functionality for default role#5701
Add STS header overrides functionality for default role#5701saketh-pallempati wants to merge 3 commits into
Conversation
The implementation includes:
- New sts_header_overrides configuration option in AwsStsConfiguration
- Extended AwsCredentialsSupplier interface to expose configured header overrides
- Implemented the method in DefaultAwsCredentialsSupplier
- Added corresponding method to CredentialsProviderFactory
- Added comprehensive test coverage
Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
saketh-pallempati
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
left a comment
graytaylor0
left a comment
There was a problem hiding this comment.
Thanks for picking this up! You'll want to wire this in here so that it will be used when configured in the data-prepper-config.yaml (https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-plugins/aws-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/CredentialsProviderFactory.java#L86). The goal of this issue is to make it so that users do not have to duplicate the sts_header_overrides everywhere within the pipeline config, and can just configure once in the data-prepper-config.yaml
- Modified CredentialsProviderFactory to use default STS header overrides when not specified in credentials options - Added test to verify fallback behavior to default configuration - Enables users to configure STS headers once in data-prepper-config.yaml instead of duplicating across pipeline configs Signed-off-by: Pallempati Saketh <pallempati.saketh@fmr.com>
|
Hi @graytaylor0 |
graytaylor0
left a comment
graytaylor0
left a comment
There was a problem hiding this comment.
Thanks for making this change!
|
@saketh-pallempati There are merge conflicts keeping me from merging this one in. |
Signed-off-by: Saketh Pallempati <pallempati.saketh@fmr.com>
saketh-pallempati
dismissed stale reviews from sb2k16 and graytaylor0
via
dd55aaf
|
Hi @graytaylor0 I resolved the merge conflicts. It one more very similar issue I worked on. |
3 participants
Description
Issues Resolved
Resolves #5530
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.