Rename Atlassian state classes to PaginationCrawler#5718
Merged
graytaylor0 merged 1 commit intoMay 23, 2025
Merged
Conversation
Signed-off-by: Alekhya Parisha <aparisha@amazon.com>
alparish
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
san81
reviewed
May 23, 2025
san81
left a comment
san81
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for generalizing these objects.
san81
approved these changes
May 23, 2025
graytaylor0
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alekhya Parisha aparisha@amazon.com
Description
This PR only includes renaming the existing state objects to be more generic and reuse the same for Atlassian as well as Office365
Renamed AtlassianLeaderProgressState to PaginationCrawlerLeaderProgressState
Renamed AtlassianWorkerProgressState to PaginationCrawlerWorkerProgressState
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.