Improvements to artifacts to support Maven artifacts for plugins.#5722
Merged
dlvenable merged 1 commit intoJun 4, 2025
Merged
Conversation
… data-prepper prefix to jar names, though they aren't used in the Maven coordinates. Move some projects into plugins or core groupIds. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
san81
reviewed
May 27, 2025
|
|
||
| subprojects { | ||
| apply plugin: 'data-prepper.publish' | ||
| group = 'org.opensearch.dataprepper.plugins.source' |
Collaborator
There was a problem hiding this comment.
All the plugins will be grouped under plugins?
Member
Author
There was a problem hiding this comment.
Yes. I think this would be the cleanest way. Not all plugin projects have only one or the other. For example, Kafka and OpenSearch have both source and sink. And Kafka also has the buffer. So this simple group approach yields more flexibility.
san81
approved these changes
May 27, 2025
kkondaka
approved these changes
May 28, 2025
jeffreyAaron
pushed a commit
to jeffreyAaron/data-prepper
that referenced
this pull request
Jun 13, 2025
… data-prepper prefix to jar names, though they aren't used in the Maven coordinates. Move some projects into plugins or core groupIds. (opensearch-project#5722) Signed-off-by: David Venable <dlv@amazon.com> Signed-off-by: Jeffrey Aaron Jeyasingh <jeffreyaaron06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR helps improve our Maven artifacts to prepare to publish Data Prepper plugins to Maven Central:
data-prepper-prefix to jar names, though they aren't used in the Maven coordinates..pluginsor.coregroupIdsIssues Resolved
Resolves #4931
Contributes toward: #5710
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.